Tarantool development patches archive
 help / color / mirror / Atom feed
* Re: [Tarantool-patches] [PATCH] build: remove libyaml from rpm/deb dependencies
       [not found] <20191008162000.66364-1-sergepetrenko@tarantool.org>
@ 2019-10-23 23:11 ` Alexander Turenko
  2019-10-23 23:53   ` Alexander Turenko
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Turenko @ 2019-10-23 23:11 UTC (permalink / raw)
  To: Serge Petrenko; +Cc: tarantool-patches, tarantool-patches

LGTM.

Added docbot comment to the issue.

Pushed to master and 2.2 (as 47b91e90f2a4e23e70a1a6735af3de203ffd59f4
itself) with minor changes for the commit message (see below).

Kirill, maybe we'll made the same changes in build process for 2.1 and
1.10? This will reduce differences between build / runtime requirements
for different tarantool versions and so maybe will be simpler for users
and developers both.

The patchset seems to be the following:

* 53fbb5879f6861e7df980d8e1db44dbef93e4ede Bump libyaml version
* cdf37876189fa005a350d6b69397348354bb2073 Extend range of printable unicode characters
* 7f4029c706a11acd09e875bb0f0fc52d66e7810d Bump libyaml version
* 47b91e90f2a4e23e70a1a6735af3de203ffd59f4 build: enable bundled libyaml for all systems.

If we'll do, please, update https://github.com/tarantool/doc/issues/960

WBR, Alexander Turenko.

On Tue, Oct 08, 2019 at 07:20:00PM +0300, Serge Petrenko wrote:
> After we started using bundled version of libyaml by default
> (see commit 47b91e90f2a4e23e70a1a6735af3de203ffd59f4), we can remove it
> from building dependencies for RPM and DEB packets.

Word 'packages' are usually used in this context, 'packets' are in
network context. I changed it.

Also reformatted the paragraph to avoid premature line breaks.

> 
> Closes #4442
> ---
> https://github.com/tarantool/tarantool/issues/4442
> https://github.com/tarantool/tarantool/tree/sp/gh-4442-rm-libyaml-deps
> 
>  debian/control     | 3 +--
>  rpm/tarantool.spec | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Tarantool-patches] [PATCH] build: remove libyaml from rpm/deb dependencies
  2019-10-23 23:11 ` [Tarantool-patches] [PATCH] build: remove libyaml from rpm/deb dependencies Alexander Turenko
@ 2019-10-23 23:53   ` Alexander Turenko
  0 siblings, 0 replies; 2+ messages in thread
From: Alexander Turenko @ 2019-10-23 23:53 UTC (permalink / raw)
  To: Serge Petrenko; +Cc: tarantool-patches, tarantool-patches

> The patchset seems to be the following:
> 
> * 53fbb5879f6861e7df980d8e1db44dbef93e4ede Bump libyaml version
> * cdf37876189fa005a350d6b69397348354bb2073 Extend range of printable unicode characters
> * 7f4029c706a11acd09e875bb0f0fc52d66e7810d Bump libyaml version
> * 47b91e90f2a4e23e70a1a6735af3de203ffd59f4 build: enable bundled libyaml for all systems.

And, of course, this patch:

* 1d4e584a7b5a5570486d7dfa6df82e664f8e0f95 build: remove libyaml from rpm/deb dependencies

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-23 23:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20191008162000.66364-1-sergepetrenko@tarantool.org>
2019-10-23 23:11 ` [Tarantool-patches] [PATCH] build: remove libyaml from rpm/deb dependencies Alexander Turenko
2019-10-23 23:53   ` Alexander Turenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox