From: Alexander Turenko <alexander.turenko@tarantool.org> To: "Alexander V. Tikhonov" <avtikhon@tarantool.org> Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1] build: added centos 8 Date: Thu, 24 Oct 2019 02:40:32 +0300 [thread overview] Message-ID: <20191023234031.ilh4xtuehzcttibz@tkn_work_nb> (raw) In-Reply-To: <702377579a50dbd8566542652d0b05baa62a0e2d.1570103318.git.avtikhon@tarantool.org> On Thu, Oct 03, 2019 at 02:49:36PM +0300, Alexander V. Tikhonov wrote: > Implemented ability to build CentOS 8 image ready for > Packpack use. Added CentOS 8 into regular testing under gitlab-ci. I don't got the first sentence. Packpack provides build images and a tool to use them. It is not something that a user need to use tarantool. > > Closes #4543 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4543-centos8 > Issue: https://github.com/tarantool/tarantool/issues/4534 > > .gitlab-ci.yml | 6 ++++++ We should add it to Travis-CI too, because deployments are made only from Travis-CI. > rpm/tarantool.spec | 9 ++++++++- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 431730b67..655e68cdc 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -152,6 +152,12 @@ centos_7: > OS: 'el' > DIST: '7' > > +centos_8: > + <<: *deploy_test_definition > + variables: > + OS: 'el' > + DIST: '8' > + > fedora_28: > <<: *deploy_test_definition > variables: > diff --git a/rpm/tarantool.spec b/rpm/tarantool.spec > index 10daf1458..5d9277576 100644 > --- a/rpm/tarantool.spec > +++ b/rpm/tarantool.spec > @@ -15,7 +15,9 @@ BuildRequires: gcc-c++ >= 4.5 > BuildRequires: coreutils > BuildRequires: sed > BuildRequires: readline-devel > +%if (0%{?fedora} > 0 || 0%{?rhel} <= 7) > BuildRequires: libyaml-devel > +%endif It will work only for 2.2+, see the comment re PowerTools in https://github.com/packpack/packpack-docker-images/pull/39 > BuildRequires: openssl-devel > BuildRequires: libicu-devel > #BuildRequires: msgpuck-devel > @@ -64,12 +66,17 @@ BuildRequires: libunwind-devel > %endif > > # For tests > -%if (0%{?fedora} >= 22 || 0%{?rhel} >= 7) > +%if (0%{?fedora} >= 22 || 0%{?rhel} == 7) > BuildRequires: python >= 2.7 > BuildRequires: python-six >= 1.9.0 > BuildRequires: python-gevent >= 1.0 > BuildRequires: python-yaml >= 3.0.9 > %endif > +%if (0%{?fedora} >= 22 || 0%{?rhel} >= 8) It seems it should be done only on rhel >= 8, not on Fedora. > +BuildRequires: python2 >= 2.7 > +BuildRequires: python2-six >= 1.9.0 > +BuildRequires: python2-yaml >= 3.0.9 We should provide python2-gevent anyway: let's add to to backports repository in https://packagecloud.io/packpack/backports > +%endif > > Name: tarantool > # ${major}.${major}.${minor}.${patch}, e.g. 1.6.8.175 > -- > 2.17.1 >
next parent reply other threads:[~2019-10-23 23:40 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <702377579a50dbd8566542652d0b05baa62a0e2d.1570103318.git.avtikhon@tarantool.org> 2019-10-23 23:40 ` Alexander Turenko [this message] 2019-10-29 10:23 Alexander V. Tikhonov 2019-10-31 13:09 ` Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191023234031.ilh4xtuehzcttibz@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [Tarantool-patches] [PATCH v1] build: added centos 8' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox