Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] build: remove libyaml from rpm/deb dependencies
Date: Thu, 24 Oct 2019 02:11:29 +0300	[thread overview]
Message-ID: <20191023231129.dqgjmyndg33e3res@tkn_work_nb> (raw)
In-Reply-To: <20191008162000.66364-1-sergepetrenko@tarantool.org>

LGTM.

Added docbot comment to the issue.

Pushed to master and 2.2 (as 47b91e90f2a4e23e70a1a6735af3de203ffd59f4
itself) with minor changes for the commit message (see below).

Kirill, maybe we'll made the same changes in build process for 2.1 and
1.10? This will reduce differences between build / runtime requirements
for different tarantool versions and so maybe will be simpler for users
and developers both.

The patchset seems to be the following:

* 53fbb5879f6861e7df980d8e1db44dbef93e4ede Bump libyaml version
* cdf37876189fa005a350d6b69397348354bb2073 Extend range of printable unicode characters
* 7f4029c706a11acd09e875bb0f0fc52d66e7810d Bump libyaml version
* 47b91e90f2a4e23e70a1a6735af3de203ffd59f4 build: enable bundled libyaml for all systems.

If we'll do, please, update https://github.com/tarantool/doc/issues/960

WBR, Alexander Turenko.

On Tue, Oct 08, 2019 at 07:20:00PM +0300, Serge Petrenko wrote:
> After we started using bundled version of libyaml by default
> (see commit 47b91e90f2a4e23e70a1a6735af3de203ffd59f4), we can remove it
> from building dependencies for RPM and DEB packets.

Word 'packages' are usually used in this context, 'packets' are in
network context. I changed it.

Also reformatted the paragraph to avoid premature line breaks.

> 
> Closes #4442
> ---
> https://github.com/tarantool/tarantool/issues/4442
> https://github.com/tarantool/tarantool/tree/sp/gh-4442-rm-libyaml-deps
> 
>  debian/control     | 3 +--
>  rpm/tarantool.spec | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)

       reply	other threads:[~2019-10-23 23:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191008162000.66364-1-sergepetrenko@tarantool.org>
2019-10-23 23:11 ` Alexander Turenko [this message]
2019-10-23 23:53   ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023231129.dqgjmyndg33e3res@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [Tarantool-patches] [PATCH] build: remove libyaml from rpm/deb dependencies' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox