From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] replication: auto reconnect if password is invalid
Date: Fri, 18 Oct 2019 01:28:05 +0300 [thread overview]
Message-ID: <20191017222805.GA19660@atlas> (raw)
In-Reply-To: <d848d875e3fa5dbb313546a963703effa239cdff.1571346959.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/10/18 00:13]:
> Before the patch there was a race in replication
> password configuration. It was possible that a replica
> connects to a master with a custom password before
> that password is actually set. The replica treated the
> error as critical and exited.
>
> But in fact it is not critical. Replica even can
> withstand absence of a user and keeps reconnecting.
> Wrong password situation arises from the same problem
> of non atomic configuration and is fixed the same -
> keep reconnect attempts if the password was wrong.
>
> Closes #4550
lgtm
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-10-17 22:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 21:16 Vladislav Shpilevoy
2019-10-17 22:28 ` Konstantin Osipov [this message]
2019-10-17 22:43 ` [Tarantool-patches] [tarantool-patches] " Vladislav Shpilevoy
2019-10-28 6:19 ` [Tarantool-patches] [tarantool-patches] " Kirill Yukhin
2019-11-14 11:20 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017222805.GA19660@atlas \
--to=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] replication: auto reconnect if password is invalid' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox