From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH 1/1] console: fix usage of an undeclared variable
Date: Fri, 18 Oct 2019 00:05:05 +0300 [thread overview]
Message-ID: <20191017210505.GD9698@uranus.lan> (raw)
In-Reply-To: <b21e39e6-ec60-9e75-fbf6-857623284663@tarantool.org>
On Thu, Oct 17, 2019 at 10:31:00PM +0200, Vladislav Shpilevoy wrote:
> >
> > We're reading from a socket and there could be EOF, which will
> > give us zero return code. But now we will start to yielding
> > an error in this case.
> >
>
> set_error is aware of that. It says 'Peer closed' on EOF.
Looks reasonable enough. Thanks!
next prev parent reply other threads:[~2019-10-17 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 19:50 [Tarantool-patches] " Vladislav Shpilevoy
2019-10-17 20:00 ` Cyrill Gorcunov
2019-10-17 20:31 ` [Tarantool-patches] [tarantool-patches] " Vladislav Shpilevoy
2019-10-17 21:05 ` Cyrill Gorcunov [this message]
2019-10-17 21:08 ` Cyrill Gorcunov
2019-10-17 21:18 ` Vladislav Shpilevoy
2019-10-17 21:15 ` Cyrill Gorcunov
2019-10-17 21:22 ` Vladislav Shpilevoy
2019-10-17 21:19 ` Cyrill Gorcunov
2019-10-17 21:26 ` Vladislav Shpilevoy
2019-10-17 21:31 ` Cyrill Gorcunov
2019-10-17 21:06 ` [Tarantool-patches] " Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017210505.GD9698@uranus.lan \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH 1/1] console: fix usage of an undeclared variable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox