From: Nikita Pettik <korablev@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v4 3/4] box: do not evaluate ck constraints on recovery
Date: Thu, 17 Oct 2019 19:28:07 +0300 [thread overview]
Message-ID: <20191017162807.GA44091@tarantool.org> (raw)
In-Reply-To: <20191017151828.GA11902@atlas>
On 17 Oct 18:18, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [19/10/17 17:41]:
> > Em, I don't see any pros of duplicating global state by passing it
> > as a parameter to functions. Meanwile using local version of force_recovery
> > may turn out to be confusing (at least for developers looking into code).
>
> Historically xlog.force_recovery is not the same as global
> force_recovery. The logic is a bit more tricky. There used to be
> panic_on_wal_error and panic_on_snap_error, and traces of it are
> still in place.
Ok, then I mean "refactor all places where global is_force_recover is the
same as argument force_recovery".
prev parent reply other threads:[~2019-10-17 16:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1570539526.git.kshcherbatov@tarantool.org>
[not found] ` <8232b0466f3878280a9ad35cb08f437610a36486.1570539526.git.kshcherbatov@tarantool.org>
2019-10-14 16:49 ` [Tarantool-patches] [tarantool-patches] [PATCH v4 1/4] box: add an ability to disable CK constraints Nikita Pettik
2019-10-15 11:13 ` [Tarantool-patches] [tarantool-patches] " Kirill Shcherbatov
2019-10-15 21:47 ` Nikita Pettik
2019-10-16 5:52 ` Konstantin Osipov
2019-10-16 11:19 ` Nikita Pettik
2019-10-16 13:50 ` Kirill Shcherbatov
2019-10-16 18:09 ` Nikita Pettik
[not found] ` <d4002407f749fff0c1f0facb1ed4cf66b8b7edd6.1570539526.git.kshcherbatov@tarantool.org>
2019-10-14 16:56 ` [Tarantool-patches] [tarantool-patches] [PATCH v4 2/4] sql: " Nikita Pettik
2019-10-15 11:13 ` [Tarantool-patches] [tarantool-patches] " Kirill Shcherbatov
2019-10-16 18:10 ` Nikita Pettik
[not found] ` <f462f55eebcb13abb8a0611a4d84d7ed8b1a6b6a.1570539526.git.kshcherbatov@tarantool.org>
[not found] ` <af095dba-bacd-e35f-9143-30ae59188697@tarantool.org>
2019-10-15 15:15 ` [Tarantool-patches] [tarantool-patches] [PATCH v4 4/4] sql: use name instead of function pointer for UDF Nikita Pettik
2019-10-16 13:51 ` [Tarantool-patches] [tarantool-patches] " Kirill Shcherbatov
2019-10-16 18:08 ` Nikita Pettik
[not found] ` <4eb8f545449842bc4c468ccf50c494e4c44c32d6.1570539526.git.kshcherbatov@tarantool.org>
[not found] ` <20191013125109.GA24391@atlas>
[not found] ` <7114925b-190a-4f0d-409f-974d2e6a65dd@tarantool.org>
2019-10-17 13:58 ` [Tarantool-patches] [tarantool-patches] Re: [PATCH v4 3/4] box: do not evaluate ck constraints on recovery Nikita Pettik
2019-10-17 14:12 ` Konstantin Osipov
2019-10-17 14:39 ` Nikita Pettik
2019-10-17 15:18 ` Konstantin Osipov
2019-10-17 16:28 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017162807.GA44091@tarantool.org \
--to=korablev@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v4 3/4] box: do not evaluate ck constraints on recovery' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox