From: Nikita Pettik <korablev@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v1 1/3] sql: errors for UDFs returning too many values
Date: Thu, 17 Oct 2019 15:51:21 +0300 [thread overview]
Message-ID: <20191017125121.GD23167@tarantool.org> (raw)
In-Reply-To: <a3e89af3-3154-c5cd-07bb-ffb32c092c84@tarantool.org>
On 16 Oct 17:10, Kirill Shcherbatov wrote:
>
> > Why not add new errcode? Like "SQL expects exactly one argument returned
> > from %s, got %d"..
> Done.
>
> >
> > Please add asserts below and fixme comment (since actually vectors are
> > supported in SQL).
> >
> > assert(argc == 1);
> > Same here.
> Done.
Pushed whole patch-set to master.
next prev parent reply other threads:[~2019-10-17 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1568639944.git.kshcherbatov@tarantool.org>
[not found] ` <05d61e713763e45d0e1d59d8c71699f9820a42cc.1568639944.git.kshcherbatov@tarantool.org>
[not found] ` <20190925155156.GA42042@tarantool.org>
[not found] ` <673fe725-f68d-e4f6-3ed0-25a4bc6255ad@tarantool.org>
2019-10-15 13:10 ` Nikita Pettik
2019-10-16 14:10 ` Kirill Shcherbatov
2019-10-17 12:51 ` Nikita Pettik [this message]
[not found] ` <c4766811-74aa-c46c-c4ca-940c991a5a90@tarantool.org>
2019-10-15 13:49 ` [Tarantool-patches] [tarantool-patches] Re: [PATCH v1 2/3] sql: better LUA arguments conversion for UDFs Nikita Pettik
2019-10-16 14:09 ` Kirill Shcherbatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017125121.GD23167@tarantool.org \
--to=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v1 1/3] sql: errors for UDFs returning too many values' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox