Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH 1/1] test: replication/misc cleanup box.cfg.replication
@ 2019-10-13 15:51 Vladislav Shpilevoy
  2019-10-17  6:28 ` Kirill Yukhin
  0 siblings, 1 reply; 2+ messages in thread
From: Vladislav Shpilevoy @ 2019-10-13 15:51 UTC (permalink / raw)
  To: tarantool-patches; +Cc: tarantool-patches, kyukhin

In patch c6bea65f8ef5f6c737cf70c0127189d0ebcbc36e I
added a bug - replication/misc leaves a bad value in
box.cfg.replication. Before that patch the test was
resetting this to empty replication. In my patch I
forgot about that, and left there the value

    {box.cfg.listen, "12345"}

This patch cleans it up.

Follow up #3760
---
Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-3760-follow-up-flaky-test
Issue: https://github.com/tarantool/tarantool/issues/3760

 test/replication/misc.result   | 2 +-
 test/replication/misc.test.lua | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/replication/misc.result b/test/replication/misc.result
index 3905cc49e..f7098aac8 100644
--- a/test/replication/misc.result
+++ b/test/replication/misc.result
@@ -842,7 +842,7 @@ box.info.status
 - running
 ...
 box.cfg{                                                        \
-    replication = replication,                                  \
+    replication = {},                                           \
     replication_connect_quorum = replication_connect_quorum,    \
     replication_connect_timeout = replication_connect_timeout   \
 }
diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua
index 696564f94..c4ddbdb47 100644
--- a/test/replication/misc.test.lua
+++ b/test/replication/misc.test.lua
@@ -342,7 +342,7 @@ box.cfg{                                                        \
 box.cfg{replication = {'localhost:12345'}}
 box.info.status
 box.cfg{                                                        \
-    replication = replication,                                  \
+    replication = {},                                           \
     replication_connect_quorum = replication_connect_quorum,    \
     replication_connect_timeout = replication_connect_timeout   \
 }
-- 
2.21.0 (Apple Git-122)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Tarantool-patches] [PATCH 1/1] test: replication/misc cleanup box.cfg.replication
  2019-10-13 15:51 [Tarantool-patches] [PATCH 1/1] test: replication/misc cleanup box.cfg.replication Vladislav Shpilevoy
@ 2019-10-17  6:28 ` Kirill Yukhin
  0 siblings, 0 replies; 2+ messages in thread
From: Kirill Yukhin @ 2019-10-17  6:28 UTC (permalink / raw)
  To: Vladislav Shpilevoy; +Cc: tarantool-patches, tarantool-patches

Hello,

On 13 окт 17:51, Vladislav Shpilevoy wrote:
> In patch c6bea65f8ef5f6c737cf70c0127189d0ebcbc36e I
> added a bug - replication/misc leaves a bad value in
> box.cfg.replication. Before that patch the test was
> resetting this to empty replication. In my patch I
> forgot about that, and left there the value
> 
>     {box.cfg.listen, "12345"}
> 
> This patch cleans it up.
> 
> Follow up #3760

I've checked yout patch into 1.10, 2.1, 2.2 and master.

--
Regards, Kirill Yukhin

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-17  6:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 15:51 [Tarantool-patches] [PATCH 1/1] test: replication/misc cleanup box.cfg.replication Vladislav Shpilevoy
2019-10-17  6:28 ` Kirill Yukhin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox