Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@dev.tarantool.org>
Subject: [Tarantool-patches] [PATCH 0/2] box/console: Fix hang on remote console enter
Date: Thu, 17 Oct 2019 00:35:29 +0300	[thread overview]
Message-ID: <20191016213531.1825-1-gorcunov@gmail.com> (raw)

Alexander pointed that we might require more precise command handling
when setting up eos in remote unix connection. Plain number of
arguments in command strem is not enough. Otherwise one could
call '\set language lua' and hang a connection.

Sasha could you please test if it fixes the problem for you?
Actually I managed to repeat it without tarantoolctl but still.

p.s.: Sorry for resending the series seems i've had a wrong relay
settings in my mail sender.

---
The following changes since commit de9a7b1a37ec34054b062c513fa1bf9357699a8d:

  sql: use name instead of function pointer for UDF (2019-10-16 21:06:48 +0300)

are available in the Git repository at:

  https://github.com/tarantool/tarantool console-enter

for you to fetch changes up to 972d23c74fb4bff72889c7b6bd0455d39a4fa688:

  box/console: Test for exact command before setting eos (2019-10-16 23:45:51 +0300)

----------------------------------------------------------------
Cyrill Gorcunov (2):
      box/console: Move param handlers into file scope
      box/console: Test for exact command before setting eos

 src/box/lua/console.lua | 36 +++++++++++++++++++++---------------
 1 file changed, 21 insertions(+), 15 deletions(-)

             reply	other threads:[~2019-10-16 21:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 21:35 Cyrill Gorcunov [this message]
2019-10-16 21:35 ` [Tarantool-patches] [PATCH 1/2] box/console: Move param handlers into file scope Cyrill Gorcunov
2019-10-16 21:35 ` [Tarantool-patches] [PATCH 2/2] box/console: Test for exact command before setting eos Cyrill Gorcunov
     [not found] <20191016205157.30836-1-gorcunov@gmail.com>
2019-10-17 12:55 ` [Tarantool-patches] [PATCH 0/2] box/console: Fix hang on remote console enter Alexander Turenko
2019-10-17 13:01   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016213531.1825-1-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] box/console: Fix hang on remote console enter' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox