From: Nikita Pettik <korablev@tarantool.org> To: Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org, Kirill Shcherbatov <kshcherbatov@tarantool.org> Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH v1 0/9] schema: rework _trigger space Date: Wed, 16 Oct 2019 14:07:39 +0300 [thread overview] Message-ID: <20191016110739.GB11847@tarantool.org> (raw) In-Reply-To: <20191016055725.GB16587@atlas> On 16 Oct 08:57, Konstantin Osipov wrote: > * Nikita Pettik <korablev@tarantool.org> [19/10/16 08:45]: > > Personally I've already said (see [dev] [rfc] Persistent triggers in Tarantool > > thread) that I do not support idea of storing both Lua and SQL trigger's > > metadata in one space. > > Well, we can not reach the point not only because we have > different opinions, but because the discussion is so slow. It is not slow, it just gets stuck.. > The reason to store all persistent objects of the same type in the > same space is that Tarantool is designed as a multiple frontend > system. I.e. tomorrow there may be another front end, not just Lua > or SQL, and one doesn't want to have a separate table for each > front end. Let's be objective: how close we are to introduce new language in Tarantool? Is there any demand for new language at all? > If the trigger timing, action type, definer, setuid and other > semantics is the same, and only the language is different, then > why duplicate the space? The thing is they are not the same. In fact, set of Lua and SQL trigger's features are quite different. In Lua trigger timing can be one of on_replace or before_replace, meanwhile in SQL trigger timing is one of BEFORE/AFTER/INSTEAD replace; In Lua action event is replace, whereas in SQL it can be INSERT/DELETE/UPDATE; FOR EACH ROW/STATEMENT action in SQL, and only FOR EACH ROW is available in Lua. > Whenever we add a new property common to > all triggers (e.g. persist enabled/disabled), we'll have to do > extra work. > > > -- > Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-10-16 11:07 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-14 16:03 [Tarantool-patches] " Kirill Shcherbatov 2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 1/9] sql: remove redundant pointer in TriggerStep Kirill Shcherbatov 2019-10-15 15:35 ` [Tarantool-patches] [tarantool-patches] " Nikita Pettik 2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 2/9] box: rename struct trigger to lua_trigger Kirill Shcherbatov 2019-10-17 7:33 ` Konstantin Osipov 2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 3/9] box: introduce trigger_event_manipulation enum Kirill Shcherbatov 2019-10-17 7:35 ` Konstantin Osipov 2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 4/9] box: introduce trigger_action_timing enum Kirill Shcherbatov 2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 5/9] sql: use rlist to organize triggers in a list Kirill Shcherbatov 2019-10-17 7:36 ` Konstantin Osipov 2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 6/9] sql: rework CREATE TABLE rule in parser Kirill Shcherbatov 2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 7/9] sql: wrap all ASTs in sql_trigger_expr structure Kirill Shcherbatov 2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 8/9] sql: inherit sql_trigger from a new trigger class Kirill Shcherbatov 2019-10-17 7:38 ` Konstantin Osipov 2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 9/9] schema: rework _trigger system space Kirill Shcherbatov 2019-10-17 7:44 ` Konstantin Osipov 2019-10-15 21:34 ` [Tarantool-patches] [tarantool-patches] [PATCH v1 0/9] schema: rework _trigger space Nikita Pettik 2019-10-16 5:57 ` Konstantin Osipov 2019-10-16 5:58 ` Konstantin Osipov 2019-10-16 11:07 ` Nikita Pettik [this message] 2019-10-16 11:11 ` Konstantin Osipov 2019-10-16 12:18 ` Nikita Pettik 2019-10-16 12:32 ` Konstantin Osipov 2019-10-16 12:47 ` Nikita Pettik 2019-10-16 12:53 ` Konstantin Osipov 2019-10-16 13:13 ` Nikita Pettik 2019-10-16 14:18 ` Konstantin Osipov 2019-10-16 12:53 ` [Tarantool-patches] [tarantool-patches] " Kirill Shcherbatov 2019-10-16 13:31 ` Nikita Pettik 2019-10-16 13:47 ` Kirill Shcherbatov 2019-10-16 20:27 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191016110739.GB11847@tarantool.org \ --to=korablev@tarantool.org \ --cc=kostja.osipov@gmail.com \ --cc=kshcherbatov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [Tarantool-patches] [tarantool-patches] [PATCH v1 0/9] schema: rework _trigger space' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox