From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] box: raise an error on nil replicaset and instance uuid
Date: Wed, 16 Oct 2019 03:12:41 +0300 [thread overview]
Message-ID: <20191016001241.rmyzmx4xhrd2umjy@tkn_work_nb> (raw)
In-Reply-To: <b424e0e94fda981935112071924c6b33c41e00ce.1567862614.git.v.shpilevoy@tarantool.org>
LGTM.
CCed Kirill.
On Sat, Sep 07, 2019 at 03:26:02PM +0200, Vladislav Shpilevoy wrote:
> Before the patch the nil UUID was ignored and a new random one
> was generated. This was because internally box treats nil UUID
> as its absense.
>
> Now a user will see an explicit message that nil UUID is a
> reserved value.
>
> Closes #4282
> ---
> Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4282-box-cfg-rs-uuid
> Issue: https://github.com/tarantool/tarantool/issues/4282
>
> src/box/box.cc | 25 +++++++++++++++++--------
> test/app-tap/cfg.test.lua | 12 +++++++++++-
> 2 files changed, 28 insertions(+), 9 deletions(-)
prev parent reply other threads:[~2019-10-16 0:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 13:26 [tarantool-patches] " Vladislav Shpilevoy
2019-09-07 13:28 ` [tarantool-patches] " Vladislav Shpilevoy
2019-09-08 12:27 ` Vladislav Shpilevoy
2019-10-16 0:12 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016001241.rmyzmx4xhrd2umjy@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] box: raise an error on nil replicaset and instance uuid' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox