From: Nikita Pettik <korablev@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v3 4/4] sql: use name instead of function pointer for UDF
Date: Mon, 14 Oct 2019 20:10:54 +0300 [thread overview]
Message-ID: <20191014171053.GC30792@tarantool.org> (raw)
In-Reply-To: <b7b6342f-b689-a959-e2a5-cef81f5f3f34@tarantool.org>
On 07 Oct 17:21, Kirill Shcherbatov wrote:
> >
> > Usually we protect pointers with schema_version, rather than avoid
> > them at all. Please take a look how iterators work.
> >
>
> We've discussed this question in T. and decided that current approach is ok except the
> necessity to rename OP_Function to OP_FunctionByName. Done.
>
> ===========================================
>
> This patch changes OP_Function parameters convention: now a
> function's name is passed instead of pointer to the function
> object. This allows to normally handle the situation, when UDF
> has been deleted to the moment of the VDBE code execution.
> In particular case this may happen with CK constraints that
> refers to a deleted persistent function.
> ---
Could you add test case covering mentioned situation?
parent reply other threads:[~2019-10-14 17:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <b7b6342f-b689-a959-e2a5-cef81f5f3f34@tarantool.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014171053.GC30792@tarantool.org \
--to=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v3 4/4] sql: use name instead of function pointer for UDF' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox