From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [server-dev] [PATCH] lua: pwd: split data fetch from deserialization
Date: Fri, 13 Sep 2019 11:15:52 +0300 [thread overview]
Message-ID: <20190913081552.4gtjkot42l76eakh@tarantool.org> (raw)
In-Reply-To: <d9ef60c9-4dc6-bfa6-d24b-f9fd0533b615@tarantool.org>
Hello,
On 05 Sep 00:02, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> LGTM.
>
> On 04/09/2019 00:42, Alexander Turenko wrote:
> > This commit does not change a user visible behaviour. It refactors pwd
> > module to explicitly divide code that fetches data from passwd / group
> > databases from code that performs deserialization of the data to Lua
> > tables.
> >
> > The idea of splitting of those actions appears when it was observed that
> > a call of getpw() / getgr() leads to problems on some systems when it is
> > invoked during passwd / group database traveral.
> >
> > Now it is more obvious that we don't call getpw() during passwd
> > traversal and getgr() during group traveral.
> >
> > Follows up #4428 and #4447.
I've checked your patch into 1.10, 2.1, 2.2 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-09-13 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8b8c10ef080d380f5b9e0ec45f5fcbdf73c209d8.1567433319.git.alexander.turenko@tarantool.org>
2019-09-04 22:02 ` Vladislav Shpilevoy
2019-09-13 8:15 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913081552.4gtjkot42l76eakh@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [server-dev] [PATCH] lua: pwd: split data fetch from deserialization' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox