Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/1] test: move luajit-tap suite to luajit repo
Date: Tue, 10 Sep 2019 17:17:03 +0300	[thread overview]
Message-ID: <20190910141701.nfiehd2usmn7t2jr@tkn_work_nb> (raw)
In-Reply-To: <dcf28de29c8dccc65b1d33e0d8b7c6b68b61276d.1567686431.git.imun@tarantool.org>

Maybe update the commit to update luajit submodule here, when we'll push
the patch to the luajit default branch (named 'tarantool')?

While we are here, it worth to update the branch in .gitmodules (now it
points to 'tarantool-1.7', but should point to 'tarantool'). If one will
use git submodule update --remote, then it can confuse. Can be done
right in this commit, just mention it in the commit message.

Out-of-source build missed small and luajit-tap test suites (it is
already so for small). Don't sure whether it should block the commit.
See more in the luajit's patch review:
https://www.freelists.org/post/tarantool-patches/PATCH-11-test-add-tests-from-tarantool-source-tree,1

WBR, Alexander Turenko.

On Thu, Sep 05, 2019 at 05:01:53PM +0300, Igor Munkin wrote:
> * All test chunks related to luajit were moved from tarantool source
> tree to the luajit repo
> * Adjusted CMakeLists via creating a symlink to luajit test directory
> to fix out-of-source tests
> 
> Closed #4478
> ---
>  .gitignore                                    |   1 +
>  test/CMakeLists.txt                           |  10 +
>  test/luajit-tap/fold_bug_LuaJIT_505.test.lua  |  20 --
>  test/luajit-tap/gh.test.lua                   |  17 --
>  test/luajit-tap/suite.ini                     |   5 -
>  .../table_chain_bug_LuaJIT_494.test.lua       | 178 ------------------
>  test/luajit-tap/unsink_64_kptr.test.lua       |  44 -----
>  7 files changed, 11 insertions(+), 264 deletions(-)
>  delete mode 100755 test/luajit-tap/fold_bug_LuaJIT_505.test.lua
>  delete mode 100755 test/luajit-tap/gh.test.lua
>  delete mode 100644 test/luajit-tap/suite.ini
>  delete mode 100755 test/luajit-tap/table_chain_bug_LuaJIT_494.test.lua
>  delete mode 100755 test/luajit-tap/unsink_64_kptr.test.lua

  reply	other threads:[~2019-09-10 14:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 14:01 [tarantool-patches] [PATCH 0/1] Move luajit-related tests " Igor Munkin
2019-09-05 14:01 ` [tarantool-patches] [PATCH 1/1] test: move luajit-tap suite " Igor Munkin
2019-09-10 14:17   ` Alexander Turenko [this message]
2019-09-10 15:49     ` [tarantool-patches] Re[2]: " Igor Munkin
2019-09-10 16:08       ` [tarantool-patches] " Alexander Turenko
2019-09-11 18:22 ` [tarantool-patches] Re: [PATCH 0/1] Move luajit-related tests " Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190910141701.nfiehd2usmn7t2jr@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 1/1] test: move luajit-tap suite to luajit repo' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox