From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@freelists.org> Cc: Konstantin Osipov <kostja@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org>, Cyrill Gorcunov <gorcunov@gmail.com> Subject: [tarantool-patches] [PATCH v3 0/6] box/console: Improve lua mode for remote console Date: Fri, 6 Sep 2019 00:28:09 +0300 [thread overview] Message-ID: <20190905212815.7311-1-gorcunov@gmail.com> (raw) This series address a problem where we can hang a connection setting up lua mode while server continue treating all data as having built-in yaml end of string terminator. We've a long discussion with @alexander.turenko about our test engine and console eos in general and at first concluded that by default we should not use ";" as lua terminator but continue using empty string instead. Actually after thinking more I fear it won't work -- a user might connect to remote console and this connection will hang because server will reply with empty eos while we're using read() from socket with terminator at the end of string. Moreover since our yaml serializer *always* yield eos terminator I think we should do the same for lua mode just to be consistent in architecture. Still for convenience I added ability to zap lua terminator via require('console').eos("") command. Thus users on local consoles can drop ';' eos if they want to. v3: - address Kostya comments The following changes since commit 51d8e4c35ca1da255b4ebea9850ec2a84365e0a3: box/memtx: strip_core -- Warn on linux only (2019-08-29 22:27:15 +0300) are available in the Git repository at: https://github.com/cyrillos/tarantool console-fix-2 for you to fetch changes up to 6c07d1f174eae99fcb86120ffd07f69e2dc6e4d2: box/console: Rename output_parse to parse_output (2019-09-06 00:03:23 +0300) ---------------------------------------------------------------- Cyrill Gorcunov (6): box/console: Add mapping for direct symbols box/console: Add explicit output EOS mapping box/console: Refactor command handling box/console: Fix hang in remote console lua mode box/console: Provide console.eos() api box/console: Rename output_parse to parse_output src/box/lua/console.lua | 149 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 132 insertions(+), 17 deletions(-)
next reply other threads:[~2019-09-05 21:28 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-05 21:28 Cyrill Gorcunov [this message] 2019-09-05 21:28 ` [tarantool-patches] [PATCH 1/6] box/console: Add mapping for direct symbols Cyrill Gorcunov 2019-09-09 15:11 ` [tarantool-patches] " Sergey Ostanevich 2019-09-09 15:54 ` [tarantool-patches] " Cyrill Gorcunov 2019-09-10 3:59 ` [tarantool-patches] Re[2]: [tarantool-patches] " Sergey Ostanevich 2019-09-05 21:28 ` [tarantool-patches] [PATCH 2/6] box/console: Add explicit output EOS mapping Cyrill Gorcunov 2019-09-05 21:28 ` [tarantool-patches] [PATCH 3/6] box/console: Refactor command handling Cyrill Gorcunov 2019-09-05 21:28 ` [tarantool-patches] [PATCH 4/6] box/console: Fix hang in remote console lua mode Cyrill Gorcunov 2019-09-05 21:28 ` [tarantool-patches] [PATCH 5/6] box/console: Provide console.eos() api Cyrill Gorcunov 2019-09-05 21:28 ` [tarantool-patches] [PATCH 6/6] box/console: Rename output_parse to parse_output Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190905212815.7311-1-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=alexander.turenko@tarantool.org \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v3 0/6] box/console: Improve lua mode for remote console' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox