From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tml <tarantool-patches@freelists.org>,
Alexander Turenko <alexander.turenko@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/5] box/console: Add explicit output EOS mapping
Date: Tue, 3 Sep 2019 11:32:14 +0300 [thread overview]
Message-ID: <20190903083214.GK2801@uranus.lan> (raw)
In-Reply-To: <20190903082725.GD9438@atlas>
On Tue, Sep 03, 2019 at 11:27:25AM +0300, Konstantin Osipov wrote:
> >
> > +local LUA_TERM = ';'
>
> term is a "terminal", not "terminator", usually. Why not call them
We simply already had
YAML_TERM = '\n...\n'
in this file, so I tried to follow naming scheme. I don't mind
rename it.
> EOF or EOS? Why did you call the constant _TERM and the array
> _eos? Why assign different names to the same thing?
Well, one of the reason is that I tried to minimize changes, but
I agree that putting everything into one place would be better.
Will rework.
>
> > + return serpent.line(..., serpent_opts) .. output_eos["lua"]
> Why put them in a table, given you never access them by a variable
> key?
because we might extend this table with time when say add sql
formatting and etc.
next prev parent reply other threads:[~2019-09-04 11:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 21:48 [tarantool-patches] [PATCH v2 0/5] box/console: Improve lua mode for remote console Cyrill Gorcunov
2019-08-30 21:48 ` [tarantool-patches] [PATCH 1/5] box/console: Add mapping for direct symbols Cyrill Gorcunov
[not found] ` <20190903082351.GB9438@atlas>
2019-09-03 8:26 ` [tarantool-patches] " Cyrill Gorcunov
[not found] ` <20190903082446.GC9438@atlas>
2019-09-03 8:28 ` Cyrill Gorcunov
2019-08-30 21:48 ` [tarantool-patches] [PATCH 2/5] box/console: Add explicit output EOS mapping Cyrill Gorcunov
[not found] ` <20190903082725.GD9438@atlas>
2019-09-03 8:32 ` Cyrill Gorcunov [this message]
2019-08-30 21:48 ` [tarantool-patches] [PATCH 3/5] box/console: Refactor command handling Cyrill Gorcunov
2019-08-30 21:48 ` [tarantool-patches] [PATCH 4/5] box/console: Fix hang in remote console lua mode Cyrill Gorcunov
[not found] ` <20190903190002.GC15611@atlas>
2019-09-03 19:18 ` [tarantool-patches] " Cyrill Gorcunov
[not found] ` <20190904064657.GD30636@atlas>
2019-09-04 7:12 ` Cyrill Gorcunov
2019-08-30 21:48 ` [tarantool-patches] [PATCH 5/5] box/console: Provide console.eos() api Cyrill Gorcunov
[not found] ` <20190903190057.GD15611@atlas>
2019-09-03 19:19 ` [tarantool-patches] " Cyrill Gorcunov
[not found] ` <20190904064725.GE30636@atlas>
2019-09-04 7:12 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903083214.GK2801@uranus.lan \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=kostja@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 2/5] box/console: Add explicit output EOS mapping' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox