From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tml <tarantool-patches@freelists.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [PATCH] box/memtx: strip_core -- Warn on linux only
Date: Fri, 30 Aug 2019 10:24:05 +0300 [thread overview]
Message-ID: <20190830072405.GD2801@uranus.lan> (raw)
In-Reply-To: <20190829221614.2ohizp2ffdz4vcoa@tkn_work_nb>
On Fri, Aug 30, 2019 at 01:16:15AM +0300, Alexander Turenko wrote:
> > Wait, do you propose to do similar compile-time check for madvise
> > feature inside tarantool code?
>
> I imagine it as two functions in small: one for check whether madvise is
> compiled-in (i.e. it is expected to be supported on a platform) and
> another (existing now) whether it is actually works. After that we can
> separately check 'is it supported on a platform' and 'is it works' from
> tarantool code to implement the logic described below.
>
> Anyway, I would not bother with all this stuff until at least one
> another feature will require something like that.
I see, thanks!
next prev parent reply other threads:[~2019-08-30 7:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 18:13 Cyrill Gorcunov
2019-08-29 10:39 ` [tarantool-patches] " Konstantin Osipov
2019-08-29 12:19 ` Alexander Turenko
2019-08-29 18:55 ` Cyrill Gorcunov
2019-08-29 22:16 ` Alexander Turenko
2019-08-30 7:24 ` Cyrill Gorcunov [this message]
2019-08-29 19:28 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830072405.GD2801@uranus.lan \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH] box/memtx: strip_core -- Warn on linux only' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox