From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [tarantool-patches] [PATCH] box/memtx: strip_core -- Warn on linux only
Date: Thu, 29 Aug 2019 22:28:45 +0300 [thread overview]
Message-ID: <20190829192845.accf2ndau2ohba5o@tarantool.org> (raw)
In-Reply-To: <20190828181322.16768-1-gorcunov@gmail.com>
Hello,
On 28 авг 21:13, Cyrill Gorcunov wrote:
> We know that madvise(MADV_DONTDUMP) is present
> on linux based platforms only (macos doesn't
> support it at all, freebsd requires MADV_NOCORE
> or similar which is unsupported by now) thus
> we should not print a warning on other systems
> to not spam users.
>
> Fixes #4464
I've checked your patch into 2.2 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-08-29 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 18:13 Cyrill Gorcunov
2019-08-29 10:39 ` [tarantool-patches] " Konstantin Osipov
2019-08-29 12:19 ` Alexander Turenko
2019-08-29 18:55 ` Cyrill Gorcunov
2019-08-29 22:16 ` Alexander Turenko
2019-08-30 7:24 ` Cyrill Gorcunov
2019-08-29 19:28 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829192845.accf2ndau2ohba5o@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] [PATCH] box/memtx: strip_core -- Warn on linux only' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox