[tarantool-patches] [PATCH v1] Set fragile option to flaky tests

[tarantool-patches] [PATCH v1] Set fragile option to flaky tests

[Alexander V. Tikhonov]

Added "fragile" option to the flaky tests that are
not intended to be run in parallel with others.
Option set at the suite.ini file at the appropriate
suites with comments including the issue that stores
the fail.
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/set-flaky-tests-fragile

 test/app/suite.ini         | 1 +
 test/box-tap/suite.ini     | 2 ++
 test/box/suite.ini         | 4 ++++
 test/engine/suite.ini      | 2 ++
 test/replication/suite.ini | 7 +++++++
 test/sql-tap/suite.ini     | 3 +++
 test/sql/suite.ini         | 2 ++
 test/vinyl/suite.ini       | 3 +++
 test/wal_off/suite.ini     | 1 +
 9 files changed, 25 insertions(+)

diff --git a/test/app/suite.ini b/test/app/suite.ini
index dd802d98c..79432e29a 100644
--- a/test/app/suite.ini
+++ b/test/app/suite.ini
@@ -7,3 +7,4 @@ use_unix_sockets = True
 use_unix_sockets_iproto = True
 is_parallel = True
 pretest_clean = True
+fragile = socket.test.lua ; gh-4426 gh-4451
diff --git a/test/box-tap/suite.ini b/test/box-tap/suite.ini
index b3ccf2e6f..8d9e32d3f 100644
--- a/test/box-tap/suite.ini
+++ b/test/box-tap/suite.ini
@@ -3,3 +3,5 @@ core = app
 description = Database tests with #! using TAP
 is_parallel = True
 pretest_clean = True
+fragile = cfg.test.lua     ; gh-4344
+          key_def.test.lua ; gh-4252
diff --git a/test/box/suite.ini b/test/box/suite.ini
index 9197e3c0f..6e8508188 100644
--- a/test/box/suite.ini
+++ b/test/box/suite.ini
@@ -9,3 +9,7 @@ use_unix_sockets = True
 use_unix_sockets_iproto = True
 is_parallel = True
 pretest_clean = True
+fragile = bitset.test.lua      ; gh-4095
+          func_reload.test.lua ; gh-4425
+          function1.test.lua   ; gh-4199
+          net.box.test.lua     ; gh-3851 gh-4383
diff --git a/test/engine/suite.ini b/test/engine/suite.ini
index ee0814dd6..5ae12a431 100644
--- a/test/engine/suite.ini
+++ b/test/engine/suite.ini
@@ -10,3 +10,5 @@ config = engine.cfg
 lua_libs = conflict.lua ../box/lua/utils.lua ../box/lua/push.lua
 is_parallel = True
 pretest_clean = True
+fragile = ddl.test.lua         ; gh-4353
+          recover_wal.test.lua ; gh-3767
diff --git a/test/replication/suite.ini b/test/replication/suite.ini
index ac35b94a7..384dac677 100644
--- a/test/replication/suite.ini
+++ b/test/replication/suite.ini
@@ -11,3 +11,10 @@ use_unix_sockets_iproto = True
 long_run = prune.test.lua
 is_parallel = True
 pretest_clean = True
+fragile = errinj.test.lua            ; gh-3870
+          join_vclock.test.lua       ; gh-4160
+          long_row_timeout.test.lua  ; gh-4351
+          skip_conflict_row.test.lua ; gh-4457
+          sync.test.lua              ; gh-3835 gh-3877
+          transaction.test.lua       ; gh-4312
+          wal_off.test.lua           ; gh-4355
diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
index 2dfae4442..ec10383ae 100644
--- a/test/sql-tap/suite.ini
+++ b/test/sql-tap/suite.ini
@@ -29,3 +29,6 @@ long_run = gh-3332-tuple-format-leak.test.lua, gh-3083-ephemeral-unref-tuples.te
 config = engine.cfg
 show_reproduce_content = False
 pretest_clean = True
+fragile = gh-3083-ephemeral-unref-tuples.test.lua ; gh-4128
+          gh-4077-iproto-execute-no-bind.test.lua ; gh-4459
+          selectG.test.lua                        ; gh-4458
diff --git a/test/sql/suite.ini b/test/sql/suite.ini
index 03c0175bf..a8664c510 100644
--- a/test/sql/suite.ini
+++ b/test/sql/suite.ini
@@ -10,3 +10,5 @@ lua_libs = lua/sql_tokenizer.lua
 release_disabled = errinj.test.lua view_delayed_wal.test.lua sql-debug.test.lua
 disabled = sql-statN-index-drop.test.lua
 pretest_clean = True
+fragile = dll.test.lua           ; gh-4427
+          func-recreate.test.lua ; gh-4384
diff --git a/test/vinyl/suite.ini b/test/vinyl/suite.ini
index 54e6618d6..c8bc270f3 100644
--- a/test/vinyl/suite.ini
+++ b/test/vinyl/suite.ini
@@ -12,3 +12,6 @@ is_parallel = True
 # throttle.test.lua temporary disabled for gh-4168
 disabled = upgrade.test.lua throttle.test.lua
 pretest_clean = True
+fragile = errinj.test.lua             ; gh-4346
+          select_consistency.test.lua ; gh-4385
+          throttle.test.lua           ; gh-4168
diff --git a/test/wal_off/suite.ini b/test/wal_off/suite.ini
index 637678c26..ed77be157 100644
--- a/test/wal_off/suite.ini
+++ b/test/wal_off/suite.ini
@@ -7,3 +7,4 @@ use_unix_sockets_iproto = True
 is_parallel = True
 pretest_clean = True
 disabled = iterator_lt_gt.test.lua
+fragile = iterator_lt_gt.test.lua ; gh-3925
-- 
2.17.1

[tarantool-patches] Re: [PATCH v1] Set fragile option to flaky tests

[Alexander Turenko]

I don't have objections here. CCed Kirill.

Does it actually makes CI more stable (for our and Travis-CI
infrastructure)? Just curious.

WBR, Alexander Turenko.

> diff --git a/test/vinyl/suite.ini b/test/vinyl/suite.ini
> index 54e6618d6..c8bc270f3 100644
> --- a/test/vinyl/suite.ini
> +++ b/test/vinyl/suite.ini
> @@ -12,3 +12,6 @@ is_parallel = True
>  # throttle.test.lua temporary disabled for gh-4168
>  disabled = upgrade.test.lua throttle.test.lua
>  pretest_clean = True
> +fragile = errinj.test.lua             ; gh-4346
> +          select_consistency.test.lua ; gh-4385
> +          throttle.test.lua           ; gh-4168
> diff --git a/test/wal_off/suite.ini b/test/wal_off/suite.ini
> index 637678c26..ed77be157 100644
> --- a/test/wal_off/suite.ini
> +++ b/test/wal_off/suite.ini
> @@ -7,3 +7,4 @@ use_unix_sockets_iproto = True
>  is_parallel = True
>  pretest_clean = True
>  disabled = iterator_lt_gt.test.lua
> +fragile = iterator_lt_gt.test.lua ; gh-3925

The test is disabled at all, should it be in fragile list too?

The same question for throttle.test.lua above (maybe other tests too, I
didn't verify it precisely).

It does not matter for me, I just observed it and point, because it may
be unintentional.

You can, say, add issue numbers to 'disabled' values: I don't mind.

[tarantool-patches] Re: [PATCH v1] Set fragile option to flaky tests

[Kirill Yukhin]

Hello,

On 27 авг 18:45, Alexander V. Tikhonov wrote:
> Added "fragile" option to the flaky tests that are
> not intended to be run in parallel with others.
> Option set at the suite.ini file at the appropriate
> suites with comments including the issue that stores
> the fail.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/set-flaky-tests-fragile

I've checked your patch into 2.1, 2.2 and master.

--
Regards, Kirill Yukhin

[tarantool-patches] Re: [PATCH v1] Set fragile option to flaky tests

[Kirill Yukhin]

Hello,

On 29 авг 19:56, Kirill Yukhin wrote:
> Hello,
> 
> On 27 авг 18:45, Alexander V. Tikhonov wrote:
> > Added "fragile" option to the flaky tests that are
> > not intended to be run in parallel with others.
> > Option set at the suite.ini file at the appropriate
> > suites with comments including the issue that stores
> > the fail.
> > ---
> > 
> > Github: https://github.com/tarantool/tarantool/tree/avtikhon/set-flaky-tests-fragile
> 
> I've checked your patch into 2.1, 2.2 and master.

Cherry-picked to 1.10 as well.

--
Regards, Kirill Yukhin