Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1] Set fragile option to flaky tests
Date: Thu, 29 Aug 2019 04:07:16 +0300	[thread overview]
Message-ID: <20190829010715.pq4z3oxxpsytf232@tkn_work_nb> (raw)
In-Reply-To: <cad5232d35355da50e13f2f1d251913186e13f15.1566920693.git.avtikhon@tarantool.org>

I don't have objections here. CCed Kirill.

Does it actually makes CI more stable (for our and Travis-CI
infrastructure)? Just curious.

WBR, Alexander Turenko.

> diff --git a/test/vinyl/suite.ini b/test/vinyl/suite.ini
> index 54e6618d6..c8bc270f3 100644
> --- a/test/vinyl/suite.ini
> +++ b/test/vinyl/suite.ini
> @@ -12,3 +12,6 @@ is_parallel = True
>  # throttle.test.lua temporary disabled for gh-4168
>  disabled = upgrade.test.lua throttle.test.lua
>  pretest_clean = True
> +fragile = errinj.test.lua             ; gh-4346
> +          select_consistency.test.lua ; gh-4385
> +          throttle.test.lua           ; gh-4168
> diff --git a/test/wal_off/suite.ini b/test/wal_off/suite.ini
> index 637678c26..ed77be157 100644
> --- a/test/wal_off/suite.ini
> +++ b/test/wal_off/suite.ini
> @@ -7,3 +7,4 @@ use_unix_sockets_iproto = True
>  is_parallel = True
>  pretest_clean = True
>  disabled = iterator_lt_gt.test.lua
> +fragile = iterator_lt_gt.test.lua ; gh-3925

The test is disabled at all, should it be in fragile list too?

The same question for throttle.test.lua above (maybe other tests too, I
didn't verify it precisely).

It does not matter for me, I just observed it and point, because it may
be unintentional.

You can, say, add issue numbers to 'disabled' values: I don't mind.

  reply	other threads:[~2019-08-29  1:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 15:45 [tarantool-patches] " Alexander V. Tikhonov
2019-08-29  1:07 ` Alexander Turenko [this message]
2019-08-29 16:56 ` [tarantool-patches] " Kirill Yukhin
2019-08-29 17:25   ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190829010715.pq4z3oxxpsytf232@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1] Set fragile option to flaky tests' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox