From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@freelists.org> Cc: Alexander Turenko <alexander.turenko@tarantool.org>, Vladimir Davydov <vdavydov.dev@gmail.com>, Cyrill Gorcunov <gorcunov@gmail.com> Subject: [PATCH] box/memtx: strip_core -- Warn on linux only Date: Wed, 28 Aug 2019 21:13:22 +0300 [thread overview] Message-ID: <20190828181322.16768-1-gorcunov@gmail.com> (raw) We know that madvise(MADV_DONTDUMP) is present on linux based platforms only (macos doesn't support it at all, freebsd requires MADV_NOCORE or similar which is unsupported by now) thus we should not print a warning on other systems to not spam users. Fixes #4464 --- Sasha, could you please check if it fixes the problem? src/main.cc | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/main.cc b/src/main.cc index 5776aa41d..b16cfa5fe 100644 --- a/src/main.cc +++ b/src/main.cc @@ -496,7 +496,19 @@ load_cfg() */ if (cfg_geti("strip_core")) { if (!small_test_feature(SMALL_FEATURE_DONTDUMP)) { - say_warn("'strip_core' is set but unsupported"); + static const char strip_msg[] = + "'strip_core' is set but unsupported"; +#ifdef TARGET_OS_LINUX + /* + * Linux is known to support madvise(DONT_DUMP) + * feature, thus warn on this platform only. The + * rest should be notified on verbose level only + * to not spam a user. + */ + say_warn(strip_msg); +#else + say_verbose(strip_msg); +#endif } } -- 2.20.1
next reply other threads:[~2019-08-28 18:13 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-28 18:13 Cyrill Gorcunov [this message] 2019-08-29 10:39 ` [tarantool-patches] " Konstantin Osipov 2019-08-29 12:19 ` Alexander Turenko 2019-08-29 18:55 ` Cyrill Gorcunov 2019-08-29 22:16 ` Alexander Turenko 2019-08-30 7:24 ` Cyrill Gorcunov 2019-08-29 19:28 ` [tarantool-patches] " Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190828181322.16768-1-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=alexander.turenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH] box/memtx: strip_core -- Warn on linux only' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox