From: Nikita Pettik <korablev@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v4 3/5] sql: remove name overloading for SQL builtins
Date: Wed, 28 Aug 2019 18:05:40 +0300 [thread overview]
Message-ID: <20190828150540.GA37199@tarantool.org> (raw)
In-Reply-To: <6c04c60a-8ae6-d1bf-0d67-943f39bd3b81@tarantool.org>
On Fri, Aug 23, 2019 at 06:02:12PM +0300, Kirill Shcherbatov wrote:
> Now all SQL builtins are unique, i.e. each function has the only
> hash table entry. This technique requires to remove static argc
> checks for some builtins(substr, round, like, trim, count,
> group_concat). Now they raise a runtime error in case of invalid
> usage.
LGTM.
PS Note that I've sent patch which fixes an assertion fault connected
with wrong number of arguments passed to GREATEST/LEAST functions:
https://www.freelists.org/post/tarantool-patches/PATCH-sql-make-GREATESTLEAST-builtins-accept-at-least-two-args
You can cherry-pick it on your branch, in case it doesn't get
to the master earlier.
next prev parent reply other threads:[~2019-08-28 15:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 15:28 [tarantool-patches] [PATCH v4 0/4] sql: uniform SQL and Lua functions subsystem Kirill Shcherbatov
2019-08-21 15:28 ` [tarantool-patches] [PATCH v4 1/4] sql: rename sql_vdbe_mem_alloc_region helper Kirill Shcherbatov
2019-08-22 13:04 ` [tarantool-patches] " n.pettik
2019-08-23 15:02 ` Kirill Shcherbatov
2019-08-21 15:28 ` [tarantool-patches] [PATCH v4 2/4] sql: replace flag MINMAX with flags MIN and MAX Kirill Shcherbatov
2019-08-22 13:30 ` [tarantool-patches] " n.pettik
2019-08-21 15:28 ` [tarantool-patches] [PATCH v4 3/4] sql: get rid of FuncDef function hash Kirill Shcherbatov
2019-08-22 14:37 ` [tarantool-patches] " n.pettik
2019-08-23 15:02 ` [tarantool-patches] [PATCH v4 4/5] " Kirill Shcherbatov
2019-08-23 15:02 ` [tarantool-patches] [PATCH v4 3/5] sql: remove name overloading for SQL builtins Kirill Shcherbatov
2019-08-28 15:05 ` Nikita Pettik [this message]
2019-08-23 15:02 ` [tarantool-patches] Re: [PATCH v4 3/4] sql: get rid of FuncDef function hash Kirill Shcherbatov
2019-08-21 15:28 ` [tarantool-patches] [PATCH v4 4/4] sql: support user-defined functions in SQL Kirill Shcherbatov
2019-08-22 15:23 ` [tarantool-patches] " n.pettik
2019-08-23 15:02 ` Kirill Shcherbatov
2019-08-29 15:09 ` [tarantool-patches] Re: [PATCH v4 0/4] sql: uniform SQL and Lua functions subsystem Nikita Pettik
2019-08-29 17:12 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828150540.GA37199@tarantool.org \
--to=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v4 3/5] sql: remove name overloading for SQL builtins' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox