From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com, Serge Petrenko <sergepetrenko@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH v3] replication: enter orphan mode on manual replication configuration chage
Date: Wed, 28 Aug 2019 14:50:35 +0300 [thread overview]
Message-ID: <20190828115035.GB32394@atlas> (raw)
In-Reply-To: <20190828112028.13875-1-sergepetrenko@tarantool.org>
* Serge Petrenko <sergepetrenko@tarantool.org> [19/08/28 14:22]:
> Currently we only enter orphan mode when instance fails to connect to
> replication_connect_quorum remote instances during local recovery.
> On bootstrap and manual replication configuration change an error is
> thrown. We better enter orphan mode on manual config change, and leave
> it only in case we managed to sync with replication_connect_quorum
> instances.
lgtm, I would call box_do_set_orphan or box_set_orphan_impl()
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-08-28 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 11:20 Serge Petrenko
2019-08-28 11:50 ` Konstantin Osipov [this message]
2019-08-28 13:58 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828115035.GB32394@atlas \
--to=kostja@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] [PATCH v3] replication: enter orphan mode on manual replication configuration chage' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox