From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Max Melentiev <m.melentiev@corp.mail.ru>
Subject: [tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET on macOS
Date: Wed, 28 Aug 2019 02:54:12 +0300 [thread overview]
Message-ID: <20190827235412.rhsroptfhxghzgun@tarantool.org> (raw)
In-Reply-To: <20190819082813.38237-1-m.melentiev@corp.mail.ru>
Hello,
On 19 авг 11:28, Max Melentiev wrote:
> To make it possible to develop and test related features on macOS.
>
> SOCK_CLOEXEC (not available on macOS) flag for socket()
> is replaced with `fcntl(fd, F_SETFD, FD_CLOEXEC)` which has the same effect.
>
> MSG_NOSIGNAL flag for sendmsg is also not available on macOS.
> However it has SO_NOSIGPIPE flag for setsockopt which disables SIGPIPE.
> So it requires different solution for different OS.
> Inspired by https://nwat.xyz/blog/2014/01/16/porting-msg_more-and-msg_nosigpipe-to-osx/
>
> `sendmsg()` is replaced with `sendto()` because `msg_namelen` was calculated incorrectly.
> New method builds message automatically without errors.
I've checked your patch into 2.2 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-08-27 23:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 8:28 [tarantool-patches] " Max Melentiev
2019-08-19 19:33 ` [tarantool-patches] " Alexander Turenko
2019-08-21 8:31 ` Maxim Melentiev
2019-08-21 15:52 ` Konstantin Osipov
2019-08-22 8:59 ` Maxim Melentiev
2019-08-22 10:06 ` Konstantin Osipov
2019-08-22 12:44 ` Maxim Melentiev
2019-08-22 13:03 ` Konstantin Osipov
2019-08-22 14:27 ` Maxim Melentiev
2019-08-23 12:11 ` Alexander Turenko
2019-08-27 23:51 ` Kirill Yukhin
2019-08-21 22:45 ` Alexander Turenko
2019-08-19 20:18 ` Konstantin Osipov
2019-08-20 15:26 ` Maxim Melentiev
2019-08-20 16:22 ` Konstantin Osipov
2019-08-27 23:54 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827235412.rhsroptfhxghzgun@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=m.melentiev@corp.mail.ru \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET on macOS' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox