Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org,
	Konstantin Osipov <kostja.osipov@gmail.com>
Subject: Re: [tarantool-patches] [PATCH] replication: do not abort replication on ER_UNKNOWN_REPLICA
Date: Tue, 27 Aug 2019 21:50:41 +0300	[thread overview]
Message-ID: <20190827185041.GQ13834@esperanza> (raw)
In-Reply-To: <20190827160720.10494-1-kostja@tarantool.org>

On Tue, Aug 27, 2019 at 07:07:20PM +0300, Konstantin Osipov wrote:
> From: Konstantin Osipov <kostja.osipov@gmail.com>
> 
> In 3-node replica-set, registering with the leader node
> does not guarantee the registration record arrives to the second
> peer immediately. The joining node may bootstrap faster than
> the registration record arrives to the second peer, in which
> case replication will fail to create a full mesh.

Makes sense. Ack.

> 
> Fixes gh-4455
> ---
>  src/box/applier.cc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/box/applier.cc b/src/box/applier.cc
> index 4304ff055..6239fcfd3 100644
> --- a/src/box/applier.cc
> +++ b/src/box/applier.cc
> @@ -100,6 +100,7 @@ applier_log_error(struct applier *applier, struct error *e)
>  	case ER_ACCESS_DENIED:
>  	case ER_NO_SUCH_USER:
>  	case ER_SYSTEM:
> +	case ER_UNKNOWN_REPLICA:
>  		say_info("will retry every %.2lf second",
>  			 replication_reconnect_interval());
>  		break;

      reply	other threads:[~2019-08-27 18:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 16:07 Konstantin Osipov
2019-08-27 18:50 ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827185041.GQ13834@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=kostja.osipov@gmail.com \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH] replication: do not abort replication on ER_UNKNOWN_REPLICA' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox