Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
	tarantool-patches@freelists.org, georgy@tarantool.org,
	Peter Gulutzan <pgulutzan@ocelot.ca>
Subject: [tarantool-patches] Re: [PATCH v2 1/3] box: rfc for stacked diagnostic area in Tarantool
Date: Tue, 27 Aug 2019 21:38:53 +0300	[thread overview]
Message-ID: <20190827183853.GC23664@atlas> (raw)
In-Reply-To: <20190826232500.zsmwfggte2fkd4ae@tkn_work_nb>

* Alexander Turenko <alexander.turenko@tarantool.org> [19/08/27 09:50]:
> > as I mentioned before, lgtm. I agree with PeterG comments, but I
> > think we can worry about them when we get to implementing SQL
> > warnings.
> 
> I think the important question here is when we clear a diagnostic area
> (if we ever want to decide now anything about warnings). Say, we
> possibly will need to entirely split warning stacks from the error stack
> and possibly will need to operate on several warning stacks.
> 
> I'm tentative that we can decide now whether we should store warnings
> within the same stack as errors or not. Maybe we should postpone all
> warnings questions now and concentrate on errors within the scope #1148.

MySQL uses a statement counter which is incremented on every
external call, and triggers a reset of the area. 

-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2019-08-27 18:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  9:59 [tarantool-patches] [PATCH v2 0/3] box: stacked diagnostics area in fiber Kirill Shcherbatov
2019-08-23  9:59 ` [tarantool-patches] [PATCH v2 1/3] box: rfc for stacked diagnostic area in Tarantool Kirill Shcherbatov
2019-08-26 22:26   ` [tarantool-patches] " Konstantin Osipov
2019-08-26 23:25     ` Alexander Turenko
2019-08-27 18:38       ` Konstantin Osipov [this message]
2019-08-30 12:58   ` Alexander Turenko
2019-08-30 13:24     ` Kirill Shcherbatov
2019-08-30 14:11       ` Alexander Turenko
2019-08-30 14:13         ` Kirill Shcherbatov
2019-08-30 14:19           ` Alexander Turenko
2019-08-23  9:59 ` [tarantool-patches] [PATCH v2 2/3] box: rename diag_add_error to diag_set_error Kirill Shcherbatov
2019-08-26 22:27   ` [tarantool-patches] " Konstantin Osipov
2019-08-23  9:59 ` [tarantool-patches] [PATCH v2 3/3] box: introduce stacked diagnostic area Kirill Shcherbatov
2019-08-26 22:34   ` [tarantool-patches] " Konstantin Osipov
2019-08-26 23:23     ` Alexander Turenko
2019-08-28  9:26       ` Konstantin Osipov
2019-08-26 22:34   ` Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827183853.GC23664@atlas \
    --to=kostja@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=georgy@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=pgulutzan@ocelot.ca \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v2 1/3] box: rfc for stacked diagnostic area in Tarantool' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox