From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org, georgy@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v2 3/3] box: introduce stacked diagnostic area
Date: Tue, 27 Aug 2019 02:23:22 +0300 [thread overview]
Message-ID: <20190826232322.rnljbredguexfppr@tkn_work_nb> (raw)
In-Reply-To: <20190826223423.GC1189@atlas>
> > + * Remove all errors set in a given diagnostics area after a
> > + * given savepoint.
> > + *
> > + * Operation removes reason for the error
> > + * preceding the savepoint and releases a diagnostic area's
> > + * reference on the most recent error (diag::last for the
> > + * rollback beginning). This means that if user code have a
> > + * pointer and have a reference to an error object from the
> > + * rollback zone, this pointer and the following "reason" error
> > + * objects are a valid error list.
> > + */
>
> BTW, did you check if anyone likes the name 'reason'? I'm not very
> fond of it, previous error is not always the reason of the current
> one. I would simply call it 'prev' or 'next'.
Can you give an example of the error that definitely should be previous
for another one, but is not its reason?
It is so for warnings, but this is possibly because they just should not
be mixed with errors within one stack.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2019-08-26 23:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 9:59 [tarantool-patches] [PATCH v2 0/3] box: stacked diagnostics area in fiber Kirill Shcherbatov
2019-08-23 9:59 ` [tarantool-patches] [PATCH v2 1/3] box: rfc for stacked diagnostic area in Tarantool Kirill Shcherbatov
2019-08-26 22:26 ` [tarantool-patches] " Konstantin Osipov
2019-08-26 23:25 ` Alexander Turenko
2019-08-27 18:38 ` Konstantin Osipov
2019-08-30 12:58 ` Alexander Turenko
2019-08-30 13:24 ` Kirill Shcherbatov
2019-08-30 14:11 ` Alexander Turenko
2019-08-30 14:13 ` Kirill Shcherbatov
2019-08-30 14:19 ` Alexander Turenko
2019-08-23 9:59 ` [tarantool-patches] [PATCH v2 2/3] box: rename diag_add_error to diag_set_error Kirill Shcherbatov
2019-08-26 22:27 ` [tarantool-patches] " Konstantin Osipov
2019-08-23 9:59 ` [tarantool-patches] [PATCH v2 3/3] box: introduce stacked diagnostic area Kirill Shcherbatov
2019-08-26 22:34 ` [tarantool-patches] " Konstantin Osipov
2019-08-26 23:23 ` Alexander Turenko [this message]
2019-08-28 9:26 ` Konstantin Osipov
2019-08-26 22:34 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826232322.rnljbredguexfppr@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=georgy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 3/3] box: introduce stacked diagnostic area' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox