From: Konstantin Osipov <kostja@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org, georgy@tarantool.org,
alexander.turenko@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v2 2/3] box: rename diag_add_error to diag_set_error
Date: Tue, 27 Aug 2019 01:27:50 +0300 [thread overview]
Message-ID: <20190826222750.GB1189@atlas> (raw)
In-Reply-To: <4f87bd09c9b37de0ec1e1b57f46923bae16a64cf.1566553968.git.kshcherbatov@tarantool.org>
* Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/08/23 13:03]:
> Renamed function diag_add_error to diag_set_error because it
> actually replaces an error object in diagnostic area with a new
> one and this name is not representative. Moreover, we are going
> to introduce a new diag_add_error that extends error object in
> diagnostic area in following patches.
lgtm, it's obvious.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-08-26 22:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 9:59 [tarantool-patches] [PATCH v2 0/3] box: stacked diagnostics area in fiber Kirill Shcherbatov
2019-08-23 9:59 ` [tarantool-patches] [PATCH v2 1/3] box: rfc for stacked diagnostic area in Tarantool Kirill Shcherbatov
2019-08-26 22:26 ` [tarantool-patches] " Konstantin Osipov
2019-08-26 23:25 ` Alexander Turenko
2019-08-27 18:38 ` Konstantin Osipov
2019-08-30 12:58 ` Alexander Turenko
2019-08-30 13:24 ` Kirill Shcherbatov
2019-08-30 14:11 ` Alexander Turenko
2019-08-30 14:13 ` Kirill Shcherbatov
2019-08-30 14:19 ` Alexander Turenko
2019-08-23 9:59 ` [tarantool-patches] [PATCH v2 2/3] box: rename diag_add_error to diag_set_error Kirill Shcherbatov
2019-08-26 22:27 ` Konstantin Osipov [this message]
2019-08-23 9:59 ` [tarantool-patches] [PATCH v2 3/3] box: introduce stacked diagnostic area Kirill Shcherbatov
2019-08-26 22:34 ` [tarantool-patches] " Konstantin Osipov
2019-08-26 23:23 ` Alexander Turenko
2019-08-28 9:26 ` Konstantin Osipov
2019-08-26 22:34 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826222750.GB1189@atlas \
--to=kostja@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=georgy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 2/3] box: rename diag_add_error to diag_set_error' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox