Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] build: fix linking with static openssl library
Date: Sun, 25 Aug 2019 14:15:38 +0300	[thread overview]
Message-ID: <20190825111538.y6rwdkq463iaex4f@tkn_work_nb> (raw)
In-Reply-To: <1cf410ba-4709-5a37-24e9-b9d660c01f92@tarantool.org>

> > Before this patch we add Z library to OPENSSL_LIBRARIES when
> > BUILD_STATIC is enabled. It is not quite correct: we should do that when
> > OPENSSL_USE_STATIC_LIBS is enabled. However we didn't experienced
> > problems with static linking of libcurl (when BUILD_STATIC is enabled),
> > because OPENSSL_LIBRARIES is added to CURL_LIBRARIES. This is a kind of
> > side effect of dependency libcurl on OpenSSL and it is better to add
> > libz explicitly to CURL_LIBRARIES (and OPENSSL_LIBRARIES) when
> > appropriate.
> 
> Is it correct, that all the curl-related changes are just sugar not
> related to the bug? Because I spent some time on attempts to understand,
> how is curl related to the problem, but looks like in no way.

It is a kind of refactoring, yep. I had understood the problem better
and so wrote better code to fix it. I would start the paragraph with a
remark like:

> The patch contains changes around linking with libcurl: they does not
> change any behaviour. Consider them as refactoring.

Then I'll describe why it is changed, why it did work before and so:
just like in the current paragraph.

I'll let you know when will update the branch.

WBR, Alexander Turenko.

  reply	other threads:[~2019-08-25 11:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  2:08 [tarantool-patches] " Alexander Turenko
2019-08-23 21:07 ` [tarantool-patches] " Vladislav Shpilevoy
2019-08-25 11:15   ` Alexander Turenko [this message]
2019-08-26 23:02     ` Alexander Turenko
2019-08-27 22:23       ` Vladislav Shpilevoy
2019-08-27 23:38 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190825111538.y6rwdkq463iaex4f@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH] build: fix linking with static openssl library' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox