Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1] gitlab-ci: clean up .gitlab-ci.yml
Date: Fri, 23 Aug 2019 14:54:33 +0300	[thread overview]
Message-ID: <20190823115433.s6yjqlxcbthnzde4@tkn_work_nb> (raw)
In-Reply-To: <72e11c07b32e8d68702754390dd0a7adcbe6101d.1566540453.git.avtikhon@tarantool.org>

The approach is okay for me. Found two mistakes. Please, fix them,
verify all jobs again and pass the patch to Kirill.

WBR, Alexander Turenko.

>  release_asan_clang8:
> -  image: ${IMAGE_TEST_LTO}
> -  stage: test
> -  tags:
> -    - docker_test
> +  <<: *docker_test_lto_definition
>    script:
>      - ${GITLAB_MAKE} test_asan_debian_no_deps

No -DENABLE_LTO=ON cmake flag. It seems that there was no before.

>  static_build:
> -  only:
> -    refs:
> -      - master
> -      - /^.*-full-ci$/
> -  stage: test
> -  tags:
> -    - deploy
> +  <<: *deploy_test_definition
>    variables:
>      RUN_TESTS: 'ON'
> -  script:
> -    - ${GITLAB_MAKE} static_build

static build now runs debian packages build.

  reply	other threads:[~2019-08-23 11:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  6:08 [tarantool-patches] " Alexander V. Tikhonov
2019-08-23 11:54 ` Alexander Turenko [this message]
2019-08-23 12:41   ` [tarantool-patches] Re: [tarantool-patches] " Alexander Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190823115433.s6yjqlxcbthnzde4@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1] gitlab-ci: clean up .gitlab-ci.yml' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox