[tarantool-patches] [PATCH] feedback: unify payload generation logic

[tarantool-patches] [PATCH] feedback: unify payload generation logic

[Yaroslav Dynnikov]

This change is related to #4391. The objective was to collect additional
information about modules, but it's hard to do without changing API.

This patch will allow to monkey-patch report generation and achieve the
same results without interfering the daemon behavior.
---
Branch: https://github.com/tarantool/tarantool/tree/rosik/gh-4391-feedback-generation
Issue: https://github.com/tarantool/tarantool/issues/4391

 src/box/lua/feedback_daemon.lua | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua
index 8a27fbd01..ad71a3fe2 100644
--- a/src/box/lua/feedback_daemon.lua
+++ b/src/box/lua/feedback_daemon.lua
@@ -37,10 +37,9 @@ end

 local function feedback_loop(self)
     fiber.name(PREFIX, { truncate = true })
-    local header = { feedback_type = "version", feedback_version = 1 }

     while true do
-        local feedback = fill_in_feedback(header)
+        local feedback = self:generate_feedback()
         local msg = self.control:get(self.interval)
         -- if msg == "send" then we simply send feedback
         if msg == "stop" then
--
2.17.1

[tarantool-patches] Re: [PATCH] feedback: unify payload generation logic

[Kirill Yukhin]

Hello,

On 21 Aug 13:30, Yaroslav Dynnikov wrote:
> This change is related to #4391. The objective was to collect additional
> information about modules, but it's hard to do without changing API.
> 
> This patch will allow to monkey-patch report generation and achieve the
> same results without interfering the daemon behavior.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/rosik/gh-4391-feedback-generation
> Issue: https://github.com/tarantool/tarantool/issues/4391

I've committed the patch into 1.10, 2.1, 2.2 and master

--
Regards, Kirill Yukhin