Tarantool development patches archive
 help / color / mirror / Atom feed
* [tarantool-patches] [PATCH] feedback: unify payload generation logic
@ 2019-08-21 10:30 Yaroslav Dynnikov
  2019-08-22 13:16 ` [tarantool-patches] " Kirill Yukhin
  0 siblings, 1 reply; 2+ messages in thread
From: Yaroslav Dynnikov @ 2019-08-21 10:30 UTC (permalink / raw)
  To: tarantool-patches; +Cc: Yaroslav Dynnikov

This change is related to #4391. The objective was to collect additional
information about modules, but it's hard to do without changing API.

This patch will allow to monkey-patch report generation and achieve the
same results without interfering the daemon behavior.
---
Branch: https://github.com/tarantool/tarantool/tree/rosik/gh-4391-feedback-generation
Issue: https://github.com/tarantool/tarantool/issues/4391

 src/box/lua/feedback_daemon.lua | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua
index 8a27fbd01..ad71a3fe2 100644
--- a/src/box/lua/feedback_daemon.lua
+++ b/src/box/lua/feedback_daemon.lua
@@ -37,10 +37,9 @@ end

 local function feedback_loop(self)
     fiber.name(PREFIX, { truncate = true })
-    local header = { feedback_type = "version", feedback_version = 1 }

     while true do
-        local feedback = fill_in_feedback(header)
+        local feedback = self:generate_feedback()
         local msg = self.control:get(self.interval)
         -- if msg == "send" then we simply send feedback
         if msg == "stop" then
--
2.17.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tarantool-patches] Re: [PATCH] feedback: unify payload generation logic
  2019-08-21 10:30 [tarantool-patches] [PATCH] feedback: unify payload generation logic Yaroslav Dynnikov
@ 2019-08-22 13:16 ` Kirill Yukhin
  0 siblings, 0 replies; 2+ messages in thread
From: Kirill Yukhin @ 2019-08-22 13:16 UTC (permalink / raw)
  To: tarantool-patches; +Cc: Yaroslav Dynnikov

Hello,

On 21 Aug 13:30, Yaroslav Dynnikov wrote:
> This change is related to #4391. The objective was to collect additional
> information about modules, but it's hard to do without changing API.
> 
> This patch will allow to monkey-patch report generation and achieve the
> same results without interfering the daemon behavior.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/rosik/gh-4391-feedback-generation
> Issue: https://github.com/tarantool/tarantool/issues/4391

I've committed the patch into 1.10, 2.1, 2.2 and master

--
Regards, Kirill Yukhin

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-22 13:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 10:30 [tarantool-patches] [PATCH] feedback: unify payload generation logic Yaroslav Dynnikov
2019-08-22 13:16 ` [tarantool-patches] " Kirill Yukhin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox