From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Max Melentiev <m.melentiev@corp.mail.ru>
Subject: [tarantool-patches] Re: [PATCH] Replace sendmsg with sendto shortcut
Date: Thu, 22 Aug 2019 16:15:23 +0300 [thread overview]
Message-ID: <20190822131523.vzrn56cifuryq7vg@tarantool.org> (raw)
In-Reply-To: <20190820120102.60158-1-m.melentiev@corp.mail.ru>
Hello,
On 20 Aug 15:01, Max Melentiev wrote:
> There is a problem with calculating .msg_namelen field
> of msghdr struct. Instead of
>
> .msg_name = &sa,
> .msg_namelen = sizeof(sa.sun_family) + strlen(sd_unix_path),
>
> it must set as
>
> .msg_namelen = sizeof(sa) // larger value than current invalid one
>
> It works on linux but when I tried to enable this feature for macOS
> it didn't (maybe because of different order of fields in the struct).
>
> Instead of fixing calculation, I've replaced original sendmsg call
> with sendto, because it's a convenient shortcut which
> simplifies code and can prevent such mistakes.
I've checked your patch into 1.10, 2.1, 2.2 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-08-22 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 12:01 [tarantool-patches] " Max Melentiev
2019-08-20 12:16 ` [tarantool-patches] " Maxim Melentiev
2019-08-20 23:34 ` Alexander Turenko
2019-08-21 8:23 ` Maxim Melentiev
2019-08-21 10:02 ` Alexander Turenko
2019-08-20 13:06 ` Konstantin Osipov
2019-08-22 13:15 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822131523.vzrn56cifuryq7vg@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=m.melentiev@corp.mail.ru \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] Replace sendmsg with sendto shortcut' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox