From: Kirill Yukhin <kyukhin@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Maxim Melentiev <m.melentiev@corp.mail.ru>,
tarantool-patches@freelists.org,
Maxim Melentiev <dmarc-noreply@freelists.org>,
Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] tarantoolctl doesn't fail when box.cfg is delayed in init script
Date: Thu, 22 Aug 2019 16:06:19 +0300 [thread overview]
Message-ID: <20190822130619.ntgehuxgnl2ymvah@tarantool.org> (raw)
In-Reply-To: <20190820231528.bqfpccu334bfxkbs@tkn_work_nb>
Hello,
On 21 Aug 02:15, Alexander Turenko wrote:
> On Tue, Aug 20, 2019 at 02:24:23PM +0300, Maxim Melentiev wrote:
> > > BTW, is this is enough for you in the scope of your task or we need to
> > > boost other tarantoolctl discussions very soon?
> > This should be enough to complete our task (with some limitations).
> >
> > However we decided not to proceed with patching tarantoolctl right now
> > and provide start/stop features in rock’s binary replacing ctl for cluster apps.
> > Thank you for review. Please, ignore this patch request.
>
> The patch looks good for me as well. Thanks!
>
> I think that it is valuable even if your team does not needed it right
> now.
>
> CCed Kirill to decide about branches to which it should land.
>
> Max, I guess a mainainer may ask you to provide a branch in
> tarantool/tarantool repository with your commit at top of current
> master.
>
> Kirill, the patch has LGTMs from Kostya O. and me.
Checked into 2.2 and master.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2019-08-22 13:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 7:39 [tarantool-patches] " Max Melentiev
2019-08-19 7:54 ` [tarantool-patches] " Konstantin Osipov
2019-08-19 9:48 ` Maxim Melentiev
2019-08-19 15:05 ` Alexander Turenko
2019-08-20 11:24 ` Maxim Melentiev
2019-08-20 11:55 ` Konstantin Osipov
2019-08-20 23:15 ` Alexander Turenko
2019-08-22 13:06 ` Kirill Yukhin [this message]
2019-08-20 11:54 ` Konstantin Osipov
2019-08-20 12:08 ` Maxim Melentiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822130619.ntgehuxgnl2ymvah@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=dmarc-noreply@freelists.org \
--cc=kostja@tarantool.org \
--cc=m.melentiev@corp.mail.ru \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] tarantoolctl doesn'\''t fail when box.cfg is delayed in init script' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox