From: Konstantin Osipov <kostja@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>,
tarantool-patches@freelists.org
Subject: Re: [PATCH v2] box: add support for decimals in update ops
Date: Thu, 22 Aug 2019 13:07:04 +0300 [thread overview]
Message-ID: <20190822100704.GC25002@atlas> (raw)
In-Reply-To: <E060B6C0-F83A-4126-BA7B-0D83E678777D@tarantool.org>
* Serge Petrenko <sergepetrenko@tarantool.org> [19/08/22 11:59]:
>
> >> Closes #4413
> >>
> >> @TarantoolBot document
> >> Title: update operations on decimal fields.
> >>
> >> tuple:update and space:update now support deicmal operands for
> >> arithmetic operations ('+' and '-'). The syntax is as usual:
> >
> > Please document how type arithmetics work, and cover it with
> > tests.
>
> Hi! I added the following text to the docbot request in commit message:
>
> «When performing an arithmetic operation ('+', '-'), where either the
> updated field or the operand is decimal, the result will be decimal.
> When both the updated field and the operand are decimal, the result
> will, of course, be decimal.»
thanks. lgtm then.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-08-22 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 8:58 Serge Petrenko
2019-08-21 10:45 ` Serge Petrenko
2019-08-21 15:09 ` Vladimir Davydov
2019-08-21 21:37 ` Konstantin Osipov
2019-08-22 8:54 ` Serge Petrenko
2019-08-22 10:07 ` Konstantin Osipov [this message]
2019-08-22 10:34 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822100704.GC25002@atlas \
--to=kostja@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v2] box: add support for decimals in update ops' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox