Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH vshard 1/1] travis-ci: deploy packages from tagged revisions
Date: Thu, 22 Aug 2019 00:25:14 +0300	[thread overview]
Message-ID: <20190821212513.rjh6s3ls32ezcnxw@tkn_work_nb> (raw)
In-Reply-To: <43985be3-143d-9e1c-cc60-ecfe94f1c3d3@tarantool.org>

On Wed, Aug 21, 2019 at 10:40:25PM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
> 
> On 21/08/2019 00:59, Alexander Turenko wrote:
> > LGTM.
> > 
> > BTW, while you are here it worth to add uploading of packages into
> > tarantool/2_3 packagecloud bucket.
> 
> I added a separate commit, see below and on the branch. Is it ok?

Looks ok.

  reply	other threads:[~2019-08-21 21:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20 20:36 [tarantool-patches] " Vladislav Shpilevoy
2019-08-20 22:59 ` [tarantool-patches] " Alexander Turenko
2019-08-21 20:40   ` Vladislav Shpilevoy
2019-08-21 21:25     ` Alexander Turenko [this message]
2019-08-21 22:13       ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821212513.rjh6s3ls32ezcnxw@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH vshard 1/1] travis-ci: deploy packages from tagged revisions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox