From: Yaroslav Dynnikov <yaroslav.dynnikov@gmail.com> To: tarantool-patches@freelists.org Cc: Yaroslav Dynnikov <yaroslav.dynnikov@gmail.com> Subject: [tarantool-patches] [PATCH] feedback: unify payload generation logic Date: Wed, 21 Aug 2019 13:30:06 +0300 [thread overview] Message-ID: <20190821103006.29438-1-yaroslav.dynnikov@gmail.com> (raw) This change is related to #4391. The objective was to collect additional information about modules, but it's hard to do without changing API. This patch will allow to monkey-patch report generation and achieve the same results without interfering the daemon behavior. --- Branch: https://github.com/tarantool/tarantool/tree/rosik/gh-4391-feedback-generation Issue: https://github.com/tarantool/tarantool/issues/4391 src/box/lua/feedback_daemon.lua | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua index 8a27fbd01..ad71a3fe2 100644 --- a/src/box/lua/feedback_daemon.lua +++ b/src/box/lua/feedback_daemon.lua @@ -37,10 +37,9 @@ end local function feedback_loop(self) fiber.name(PREFIX, { truncate = true }) - local header = { feedback_type = "version", feedback_version = 1 } while true do - local feedback = fill_in_feedback(header) + local feedback = self:generate_feedback() local msg = self.control:get(self.interval) -- if msg == "send" then we simply send feedback if msg == "stop" then -- 2.17.1
next reply other threads:[~2019-08-21 10:30 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-21 10:30 Yaroslav Dynnikov [this message] 2019-08-22 13:16 ` [tarantool-patches] " Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190821103006.29438-1-yaroslav.dynnikov@gmail.com \ --to=yaroslav.dynnikov@gmail.com \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH] feedback: unify payload generation logic' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox