Tarantool development patches archive
 help / color / mirror / Atom feed
* [tarantool-patches] [PATCH vshard 1/1] travis-ci: deploy packages from tagged revisions
@ 2019-08-20 20:36 Vladislav Shpilevoy
  2019-08-20 22:59 ` [tarantool-patches] " Alexander Turenko
  0 siblings, 1 reply; 5+ messages in thread
From: Vladislav Shpilevoy @ 2019-08-20 20:36 UTC (permalink / raw)
  To: tarantool-patches; +Cc: alexander.turenko

Travis considers push of a commit and of a tag as different
events. If tags are not described explicitly, it does not
trigger publication when only a tag is pushed.
---
Branch: https://github.com/tarantool/vshard/tree/gerold103/deploy-from-tags

 .travis.yml | 46 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 45 insertions(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 1294191..f13a481 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -39,7 +39,7 @@ before_deploy:
   - ls -l build/
 
 deploy:
-  # Deploy packages to PackageCloud
+  # Deploy packages to PackageCloud from master branch
   - provider: packagecloud
     username: tarantool
     repository: "1_9"
@@ -80,6 +80,50 @@ deploy:
     on:
       branch: "master"
       condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
+    # Deploy packages to PackageCloud from tags
+    # see:
+    #   * https://github.com/tarantool/tarantool/issues/3745
+    #   * https://github.com/travis-ci/travis-ci/issues/7780#issuecomment-302389370
+    - provider: packagecloud
+    username: tarantool
+    repository: "1_9"
+    token: ${PACKAGECLOUD_TOKEN}
+    dist: ${OS}/${DIST}
+    package_glob: build/*.{deb,rpm,dsc}
+    skip_cleanup: true
+    on:
+      tags: true
+      condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
+  - provider: packagecloud
+    username: tarantool
+    repository: "1_10"
+    token: ${PACKAGECLOUD_TOKEN}
+    dist: ${OS}/${DIST}
+    package_glob: build/*.{deb,rpm,dsc}
+    skip_cleanup: true
+    on:
+      tags: true
+      condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
+  - provider: packagecloud
+    username: tarantool
+    repository: "2x"
+    token: ${PACKAGECLOUD_TOKEN}
+    dist: ${OS}/${DIST}
+    package_glob: build/*.{deb,rpm,dsc}
+    skip_cleanup: true
+    on:
+      tags: true
+      condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
+  - provider: packagecloud
+    username: tarantool
+    repository: "2_2"
+    token: ${PACKAGECLOUD_TOKEN}
+    dist: ${OS}/${DIST}
+    package_glob: build/*.{deb,rpm,dsc}
+    skip_cleanup: true
+    on:
+      tags: true
+      condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
 
 notifications:
   email:
-- 
2.20.1 (Apple Git-117)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tarantool-patches] Re: [PATCH vshard 1/1] travis-ci: deploy packages from tagged revisions
  2019-08-20 20:36 [tarantool-patches] [PATCH vshard 1/1] travis-ci: deploy packages from tagged revisions Vladislav Shpilevoy
@ 2019-08-20 22:59 ` Alexander Turenko
  2019-08-21 20:40   ` Vladislav Shpilevoy
  0 siblings, 1 reply; 5+ messages in thread
From: Alexander Turenko @ 2019-08-20 22:59 UTC (permalink / raw)
  To: Vladislav Shpilevoy; +Cc: tarantool-patches

LGTM.

BTW, while you are here it worth to add uploading of packages into
tarantool/2_3 packagecloud bucket.

WBR, Alexander Turenko.

On Tue, Aug 20, 2019 at 10:36:18PM +0200, Vladislav Shpilevoy wrote:
> Travis considers push of a commit and of a tag as different
> events. If tags are not described explicitly, it does not
> trigger publication when only a tag is pushed.
> ---
> Branch: https://github.com/tarantool/vshard/tree/gerold103/deploy-from-tags
> 
>  .travis.yml | 46 +++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 45 insertions(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 1294191..f13a481 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -39,7 +39,7 @@ before_deploy:
>    - ls -l build/
>  
>  deploy:
> -  # Deploy packages to PackageCloud
> +  # Deploy packages to PackageCloud from master branch
>    - provider: packagecloud
>      username: tarantool
>      repository: "1_9"
> @@ -80,6 +80,50 @@ deploy:
>      on:
>        branch: "master"
>        condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
> +    # Deploy packages to PackageCloud from tags
> +    # see:
> +    #   * https://github.com/tarantool/tarantool/issues/3745
> +    #   * https://github.com/travis-ci/travis-ci/issues/7780#issuecomment-302389370
> +    - provider: packagecloud
> +    username: tarantool
> +    repository: "1_9"
> +    token: ${PACKAGECLOUD_TOKEN}
> +    dist: ${OS}/${DIST}
> +    package_glob: build/*.{deb,rpm,dsc}
> +    skip_cleanup: true
> +    on:
> +      tags: true
> +      condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
> +  - provider: packagecloud
> +    username: tarantool
> +    repository: "1_10"
> +    token: ${PACKAGECLOUD_TOKEN}
> +    dist: ${OS}/${DIST}
> +    package_glob: build/*.{deb,rpm,dsc}
> +    skip_cleanup: true
> +    on:
> +      tags: true
> +      condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
> +  - provider: packagecloud
> +    username: tarantool
> +    repository: "2x"
> +    token: ${PACKAGECLOUD_TOKEN}
> +    dist: ${OS}/${DIST}
> +    package_glob: build/*.{deb,rpm,dsc}
> +    skip_cleanup: true
> +    on:
> +      tags: true
> +      condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
> +  - provider: packagecloud
> +    username: tarantool
> +    repository: "2_2"
> +    token: ${PACKAGECLOUD_TOKEN}
> +    dist: ${OS}/${DIST}
> +    package_glob: build/*.{deb,rpm,dsc}
> +    skip_cleanup: true
> +    on:
> +      tags: true
> +      condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
>  
>  notifications:
>    email:
> -- 
> 2.20.1 (Apple Git-117)
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tarantool-patches] Re: [PATCH vshard 1/1] travis-ci: deploy packages from tagged revisions
  2019-08-20 22:59 ` [tarantool-patches] " Alexander Turenko
@ 2019-08-21 20:40   ` Vladislav Shpilevoy
  2019-08-21 21:25     ` Alexander Turenko
  0 siblings, 1 reply; 5+ messages in thread
From: Vladislav Shpilevoy @ 2019-08-21 20:40 UTC (permalink / raw)
  To: Alexander Turenko; +Cc: tarantool-patches

Hi! Thanks for the review!

On 21/08/2019 00:59, Alexander Turenko wrote:
> LGTM.
> 
> BTW, while you are here it worth to add uploading of packages into
> tarantool/2_3 packagecloud bucket.

I added a separate commit, see below and on the branch. Is it ok?

========================================================================

    travis-ci: deploy to 2_3 repo

diff --git a/.travis.yml b/.travis.yml
index f13a481..024ab27 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -80,6 +80,16 @@ deploy:
     on:
       branch: "master"
       condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
+  - provider: packagecloud
+    username: tarantool
+    repository: "2_3"
+    token: ${PACKAGECLOUD_TOKEN}
+    dist: ${OS}/${DIST}
+    package_glob: build/*.{deb,rpm,dsc}
+    skip_cleanup: true
+    on:
+      branch: "master"
+      condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
     # Deploy packages to PackageCloud from tags
     # see:
     #   * https://github.com/tarantool/tarantool/issues/3745
@@ -124,6 +134,16 @@ deploy:
     on:
       tags: true
       condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
+  - provider: packagecloud
+    username: tarantool
+    repository: "2_3"
+    token: ${PACKAGECLOUD_TOKEN}
+    dist: ${OS}/${DIST}
+    package_glob: build/*.{deb,rpm,dsc}
+    skip_cleanup: true
+    on:
+      tags: true
+      condition: -n "${OS}" && -n "${DIST}" && -n "${PACKAGECLOUD_TOKEN}"
 
 notifications:
   email:

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tarantool-patches] Re: [PATCH vshard 1/1] travis-ci: deploy packages from tagged revisions
  2019-08-21 20:40   ` Vladislav Shpilevoy
@ 2019-08-21 21:25     ` Alexander Turenko
  2019-08-21 22:13       ` Vladislav Shpilevoy
  0 siblings, 1 reply; 5+ messages in thread
From: Alexander Turenko @ 2019-08-21 21:25 UTC (permalink / raw)
  To: Vladislav Shpilevoy; +Cc: tarantool-patches

On Wed, Aug 21, 2019 at 10:40:25PM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
> 
> On 21/08/2019 00:59, Alexander Turenko wrote:
> > LGTM.
> > 
> > BTW, while you are here it worth to add uploading of packages into
> > tarantool/2_3 packagecloud bucket.
> 
> I added a separate commit, see below and on the branch. Is it ok?

Looks ok.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tarantool-patches] Re: [PATCH vshard 1/1] travis-ci: deploy packages from tagged revisions
  2019-08-21 21:25     ` Alexander Turenko
@ 2019-08-21 22:13       ` Vladislav Shpilevoy
  0 siblings, 0 replies; 5+ messages in thread
From: Vladislav Shpilevoy @ 2019-08-21 22:13 UTC (permalink / raw)
  To: Alexander Turenko; +Cc: tarantool-patches

Pushed to the master.

On 21/08/2019 23:25, Alexander Turenko wrote:
> On Wed, Aug 21, 2019 at 10:40:25PM +0200, Vladislav Shpilevoy wrote:
>> Hi! Thanks for the review!
>>
>> On 21/08/2019 00:59, Alexander Turenko wrote:
>>> LGTM.
>>>
>>> BTW, while you are here it worth to add uploading of packages into
>>> tarantool/2_3 packagecloud bucket.
>>
>> I added a separate commit, see below and on the branch. Is it ok?
> 
> Looks ok.
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-08-21 22:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 20:36 [tarantool-patches] [PATCH vshard 1/1] travis-ci: deploy packages from tagged revisions Vladislav Shpilevoy
2019-08-20 22:59 ` [tarantool-patches] " Alexander Turenko
2019-08-21 20:40   ` Vladislav Shpilevoy
2019-08-21 21:25     ` Alexander Turenko
2019-08-21 22:13       ` Vladislav Shpilevoy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox