Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Maxim Melentiev <m.melentiev@corp.mail.ru>
Cc: tarantool-patches@freelists.org,
	Maxim Melentiev <dmarc-noreply@freelists.org>,
	alexander.turenko@tarantool.org
Subject: [tarantool-patches] Re: [PATCH] tarantoolctl doesn't fail when box.cfg is delayed in init script
Date: Tue, 20 Aug 2019 14:55:58 +0300	[thread overview]
Message-ID: <20190820115558.GE8932@atlas> (raw)
In-Reply-To: <F1B24774-3EA8-4960-BE95-2E63640DD8EC@corp.mail.ru>

* Maxim Melentiev <m.melentiev@corp.mail.ru> [19/08/20 14:28]:
> `tarantoolctl start` patches box.cfg two times:
> 1) before the init script to set default values and enforce some others,
> 2) after the init script to prevent changing a pid_file in runtime.
> 

This comment is even better so it's obviously also lgtm.

 

-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2019-08-20 11:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19  7:39 [tarantool-patches] " Max Melentiev
2019-08-19  7:54 ` [tarantool-patches] " Konstantin Osipov
2019-08-19  9:48   ` Maxim Melentiev
2019-08-19 15:05     ` Alexander Turenko
2019-08-20 11:24       ` Maxim Melentiev
2019-08-20 11:55         ` Konstantin Osipov [this message]
2019-08-20 23:15         ` Alexander Turenko
2019-08-22 13:06           ` Kirill Yukhin
2019-08-20 11:54     ` Konstantin Osipov
2019-08-20 12:08   ` Maxim Melentiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820115558.GE8932@atlas \
    --to=kostja@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=dmarc-noreply@freelists.org \
    --cc=m.melentiev@corp.mail.ru \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] tarantoolctl doesn'\''t fail when box.cfg is delayed in init script' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox