From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2 6/7] space: get rid of apply_initial_join_row method
Date: Mon, 19 Aug 2019 23:54:14 +0300 [thread overview]
Message-ID: <20190819205414.GG21602@atlas> (raw)
In-Reply-To: <f104e5fc496c87259649f046012fc06156656078.1566233187.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/08/19 19:57]:
> There's no reason to use a special method instead of the generic
> space_execute_dml for applying rows received from a master during the
> initial join stage. Moreover, using the special method results in not
> running space.before_replace trigger, which makes it impossible to, for
> example, update space engine on a replica, see the on_schema_init test
> of the replication test suite.
>
> So this patch removes the special method altogether and makes the code
> that used it switch to space_execute_dml.
>
> Closes #4417
LGTM
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-08-19 20:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 16:53 [PATCH v2 0/7] Join replicas off the current read view Vladimir Davydov
2019-08-19 16:53 ` [PATCH v2 1/7] vinyl: don't pin index for iterator lifetime Vladimir Davydov
2019-08-19 20:35 ` [tarantool-patches] " Konstantin Osipov
2019-08-19 16:53 ` [PATCH v2 2/7] vinyl: don't exempt dropped indexes from dump and compaction Vladimir Davydov
2019-08-19 20:47 ` [tarantool-patches] " Konstantin Osipov
2019-08-20 8:12 ` Vladimir Davydov
2019-08-20 9:02 ` Vladimir Davydov
2019-08-20 11:52 ` Konstantin Osipov
2019-08-20 14:16 ` Vladimir Davydov
2019-08-19 16:53 ` [PATCH v2 3/7] vinyl: get rid of vy_env::join_lsn Vladimir Davydov
2019-08-19 20:49 ` [tarantool-patches] " Konstantin Osipov
2019-08-19 16:53 ` [PATCH v2 4/7] memtx: use ref counting to pin indexes for snapshot Vladimir Davydov
2019-08-19 20:50 ` [tarantool-patches] " Konstantin Osipov
2019-08-19 16:53 ` [PATCH v2 5/7] memtx: enter small delayed free mode from snapshot iterator Vladimir Davydov
2019-08-19 20:51 ` [tarantool-patches] " Konstantin Osipov
2019-08-19 16:53 ` [PATCH v2 6/7] space: get rid of apply_initial_join_row method Vladimir Davydov
2019-08-19 20:54 ` Konstantin Osipov [this message]
2019-08-19 16:53 ` [PATCH v2 7/7] relay: join new replicas off read view Vladimir Davydov
2019-08-19 20:57 ` [tarantool-patches] " Konstantin Osipov
2019-08-20 8:16 ` Vladimir Davydov
2019-08-20 11:53 ` Konstantin Osipov
2019-08-20 12:05 ` Vladimir Davydov
2019-08-20 13:50 ` Konstantin Osipov
2019-08-20 14:03 ` Vladimir Davydov
2019-08-21 22:08 ` Konstantin Osipov
2019-08-22 8:05 ` Vladimir Davydov
2019-08-19 16:54 ` [PATCH v2 0/7] Join replicas off the current " Vladimir Davydov
2019-08-20 8:53 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819205414.GG21602@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 6/7] space: get rid of apply_initial_join_row method' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox