Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1] gitlab-ci: add static build
Date: Fri, 16 Aug 2019 05:30:09 +0300	[thread overview]
Message-ID: <20190816023008.ean2vrvwablefviu@tkn_work_nb> (raw)
In-Reply-To: <dd7e013dd8b2b16a9f2b46d8a44a226b004b9356.1565325077.git.avtikhon@tarantool.org>

I looked briefly and it seems to be okay. But, please, remove cleanup
changes from the dockerfile: they hide real changes and bloats the
patch.

I'll look deeper when you'll update the patch.

WBR, Alexander Turenko.

> -RUN set -x \
> -    && yum -y install \
> +RUN set -x && \
> +    yum -y install \

I meant this kind of changes.

> -RUN yum -y install ncurses-static readline-static zlib-static pcre-static glibc-static
> +    yum -y install \
> +        ncurses-static \
> +        readline-static \
> +        zlib-static \
> +        pcre-static \
> +        glibc-static && \
> +    yum -y install \
> +        python-devel \
> +        python-pip

This.

> +WORKDIR /
>  
>  RUN set -x && \
> -    cd / && \
>      curl -O -L https://www.openssl.org/source/openssl-1.1.0h.tar.gz && \
>      tar -xvf openssl-1.1.0h.tar.gz && \
>      cd openssl-1.1.0h && \

And this.

  reply	other threads:[~2019-08-16  2:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  4:32 [tarantool-patches] " Alexander V. Tikhonov
2019-08-16  2:30 ` Alexander Turenko [this message]
2019-08-16  9:57   ` [tarantool-patches] Re: [tarantool-patches] " Alexander Tikhonov
2019-08-16  9:55 [tarantool-patches] " Alexander V. Tikhonov
2019-08-19 12:00 ` [tarantool-patches] " Alexander Turenko
2019-08-20  9:32 [tarantool-patches] " Alexander V. Tikhonov
2019-08-20 22:02 ` [tarantool-patches] " Alexander Turenko
2019-08-21 11:07   ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190816023008.ean2vrvwablefviu@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1] gitlab-ci: add static build' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox