From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@freelists.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
Konstantin Osipov <kostja@tarantool.org>,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [tarantool-patches] [PATCH 1/4] box/console: Add explicit output EOS mapping
Date: Thu, 15 Aug 2019 17:42:54 +0300 [thread overview]
Message-ID: <20190815144257.9405-2-gorcunov@gmail.com> (raw)
In-Reply-To: <20190815144257.9405-1-gorcunov@gmail.com>
This will help us to distinguish end of string/stream
in text protocols (such as remote console connection).
Note that we start printing ";" terminator for every
lua output. Actually current yaml output does the
same but inside console.c module.
And since lua output is yet a new feature in stabilization
phase we're safe to make such changes without breaking api.
Part-of #3834
---
src/box/lua/console.lua | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/box/lua/console.lua b/src/box/lua/console.lua
index 64086cf5b..be277d610 100644
--- a/src/box/lua/console.lua
+++ b/src/box/lua/console.lua
@@ -11,6 +11,7 @@ local urilib = require('uri')
local yaml = require('yaml')
local net_box = require('net.box')
+local LUA_TERM = ';'
local YAML_TERM = '\n...\n'
local PUSH_TAG_HANDLE = '!push!'
@@ -19,6 +20,10 @@ local PUSH_TAG_HANDLE = '!push!'
-- compatibility reason.
local default_output_format = { ["fmt"] = "yaml", ["opts"] = nil }
local output_handlers = { }
+--
+-- End of streams/strings. They will allow to recognize blocks
+-- depending on output format.
+local output_eos = { ["yaml"] = YAML_TERM, ["lua"] = LUA_TERM }
output_handlers["yaml"] = function(status, opts, ...)
local err
@@ -42,9 +47,11 @@ end
output_handlers["lua"] = function(status, opts, ...)
--
- -- Don't print nil if there is no data
+ -- If no data present at least EOS should be put,
+ -- otherwise wire readers won't be able to find
+ -- where end of string is.
if not ... then
- return ""
+ return output_eos["lua"]
end
--
-- Map internal symbols which serpent doesn't know
@@ -64,9 +71,9 @@ output_handlers["lua"] = function(status, opts, ...)
nocode = true,
}
if opts == "block" then
- return serpent.block(..., serpent_opts)
+ return serpent.block(..., serpent_opts) .. output_eos["lua"]
end
- return serpent.line(..., serpent_opts)
+ return serpent.line(..., serpent_opts) .. output_eos["lua"]
end
local function output_verify_opts(fmt, opts)
--
2.20.1
next prev parent reply other threads:[~2019-08-15 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 14:42 [tarantool-patches] [PATCH 0/4] box/console: Improve lua mode for remote console Cyrill Gorcunov
2019-08-15 14:42 ` Cyrill Gorcunov [this message]
2019-08-15 14:42 ` [tarantool-patches] [PATCH 2/4] box/console: Refactor command handling Cyrill Gorcunov
2019-08-15 14:42 ` [tarantool-patches] [PATCH 3/4] box/console: Fix hang in remote console lua mode Cyrill Gorcunov
2019-08-15 14:42 ` [tarantool-patches] [PATCH 4/4] box/console: Provide console.eos() api Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815144257.9405-2-gorcunov@gmail.com \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH 1/4] box/console: Add explicit output EOS mapping' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox