Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@freelists.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
	Konstantin Osipov <kostja@tarantool.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [tarantool-patches] [PATCH 0/4] box/console: Improve lua mode for remote console
Date: Thu, 15 Aug 2019 17:42:53 +0300	[thread overview]
Message-ID: <20190815144257.9405-1-gorcunov@gmail.com> (raw)

This series address a problem where we can hang a connection setting up
lua mode while server continue treating all data as having built-in yaml
end of string terminator.

I've tested the series manually (and since we still use yaml as a default
output it should not break anything existing) but my next priority is
lifting up our test engine and use new require('console').eos() helper
inside to be able to read lua replies from server test jobs.

Thus I post the series asap just to gather feedback.

The following changes since commit 2d5e56fffe894c1fb77fe77bcf12b34da772b2a7:

  wal: make wal_sync fail on write error (2019-08-14 19:43:10 +0300)

are available in the Git repository at:

  https://github.com/cyrillos/tarantool.git console-fix-1

for you to fetch changes up to 396e9a5f6e3ec0fb03c6603ecaef59ee7073420c:

  box/console: Provide console.eos() api (2019-08-15 17:30:33 +0300)

----------------------------------------------------------------
Cyrill Gorcunov (4):
      box/console: Add explicit output EOS mapping
      box/console: Refactor command handling
      box/console: Fix hang in remote console lua mode
      box/console: Provide console.eos() api

 src/box/lua/console.lua | 107 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 94 insertions(+), 13 deletions(-)
-- 
2.20.1

             reply	other threads:[~2019-08-15 14:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 14:42 Cyrill Gorcunov [this message]
2019-08-15 14:42 ` [tarantool-patches] [PATCH 1/4] box/console: Add explicit output EOS mapping Cyrill Gorcunov
2019-08-15 14:42 ` [tarantool-patches] [PATCH 2/4] box/console: Refactor command handling Cyrill Gorcunov
2019-08-15 14:42 ` [tarantool-patches] [PATCH 3/4] box/console: Fix hang in remote console lua mode Cyrill Gorcunov
2019-08-15 14:42 ` [tarantool-patches] [PATCH 4/4] box/console: Provide console.eos() api Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190815144257.9405-1-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=alexander.turenko@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH 0/4] box/console: Improve lua mode for remote console' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox