[tarantool-patches] Re: [PATCH] recovery: build secondary index in hot standby mode

[Konstantin Osipov <kostja@tarantool.org>]

* Ilya Kosarev <i.kosarev@tarantool.org> [19/08/14 21:36]:
> Secondary index was being built after reading xlog
> except for the force recovery case,
> when it was being built immediately after reading snapshot.
> Now it is also being built immediately after reading snapshot
> in case of hot standby mode in order to be ready by the time
> original instance quits.
> 
> Closes #4135
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4135-secondary-index-for-hot-standby
> Issue: https://github.com/tarantool/tarantool/issues/4135
> 
>  src/box/memtx_engine.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/box/memtx_engine.c b/src/box/memtx_engine.c
> index 7c3dd8465..2c8653bd9 100644
> --- a/src/box/memtx_engine.c
> +++ b/src/box/memtx_engine.c
> @@ -48,6 +48,7 @@
>  #include "replication.h"
>  #include "schema.h"
>  #include "gc.h"
> +#include "wal.h"

This should not be done by including entire WAL API header..

I wonder maybe we should have a policy that discourages including
extra headers?

-- 
Konstantin Osipov, Moscow, Russia