Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: georgy@tarantool.org, i.kosarev@corp.mail.ru,
	Ilya Kosarev <i.kosarev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] recovery: build secondary index in hot standby mode
Date: Thu, 15 Aug 2019 01:12:32 +0300	[thread overview]
Message-ID: <20190814221232.GB28533@atlas> (raw)
In-Reply-To: <20190814183144.17907-1-i.kosarev@tarantool.org>

* Ilya Kosarev <i.kosarev@tarantool.org> [19/08/14 21:36]:
> Secondary index was being built after reading xlog
> except for the force recovery case,
> when it was being built immediately after reading snapshot.
> Now it is also being built immediately after reading snapshot
> in case of hot standby mode in order to be ready by the time
> original instance quits.
> 
> Closes #4135
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4135-secondary-index-for-hot-standby
> Issue: https://github.com/tarantool/tarantool/issues/4135
> 
>  src/box/memtx_engine.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/box/memtx_engine.c b/src/box/memtx_engine.c
> index 7c3dd8465..2c8653bd9 100644
> --- a/src/box/memtx_engine.c
> +++ b/src/box/memtx_engine.c
> @@ -48,6 +48,7 @@
>  #include "replication.h"
>  #include "schema.h"
>  #include "gc.h"
> +#include "wal.h"

This should not be done by including entire WAL API header..

I wonder maybe we should have a policy that discourages including
extra headers?

-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2019-08-14 22:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 18:31 [tarantool-patches] " Ilya Kosarev
2019-08-14 22:12 ` Konstantin Osipov [this message]
2019-09-10 14:40 ` [tarantool-patches] " Georgy Kirichenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190814221232.GB28533@atlas \
    --to=kostja@tarantool.org \
    --cc=georgy@tarantool.org \
    --cc=i.kosarev@corp.mail.ru \
    --cc=i.kosarev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] recovery: build secondary index in hot standby mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox