From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v1] test: app/socket flaky fails at 1118 line
Date: Wed, 14 Aug 2019 15:12:18 +0300 [thread overview]
Message-ID: <20190814121218.GG13834@esperanza> (raw)
In-Reply-To: <dd0bf0616c780d100dce4601dbe22798444756ba.1565760376.git.avtikhon@tarantool.org>
On Wed, Aug 14, 2019 at 08:27:59AM +0300, Alexander V. Tikhonov wrote:
> diff --git a/test/app/socket.test.lua b/test/app/socket.test.lua
> index 7ae9a98aa..68ac4b4ac 100644
> --- a/test/app/socket.test.lua
> +++ b/test/app/socket.test.lua
> @@ -359,7 +359,12 @@ test_run:cmd("setopt delimiter ''");
>
> s = socket.tcp_connect('127.0.0.1', port)
> ch = fiber.channel()
> -f = fiber.create(function() s:read(12) ch:put(true) end)
> +test_run:cmd("setopt delimiter ';'")
> +f = fiber.create(function()
> + s:read(12)
> + ch:put(true)
> +end);
> +test_run:cmd("setopt delimiter ''");
> s:close()
> ch:get(1)
> s:error()
For the record. Discussed f2f, agreed that this patch doesn't make any
difference. There must be some other explanation of the test failure.
prev parent reply other threads:[~2019-08-14 12:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 5:27 Alexander V. Tikhonov
2019-08-14 12:12 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814121218.GG13834@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v1] test: app/socket flaky fails at 1118 line' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox