From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 06/13] memtx: don't store pointers to index internals in iterator
Date: Tue, 13 Aug 2019 01:21:57 +0300 [thread overview]
Message-ID: <20190812222157.GY32337@atlas> (raw)
In-Reply-To: <ec709a117844f1fd4b771ccf88c3286ddfb656bb.1565430177.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/08/10 23:22]:
> It's pointless as we can always access the index via iterator->index.
> ---
> src/box/memtx_bitset.c | 10 ++-----
> src/box/memtx_hash.c | 20 ++++++-------
> src/box/memtx_tree.c | 67 +++++++++++++++++++++++-------------------
> 3 files changed, 49 insertions(+), 48 deletions(-)
lgtm
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-08-12 22:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 10:03 [PATCH 00/13] Join replicas off the current read view Vladimir Davydov
2019-08-10 10:03 ` [PATCH 01/13] vinyl: embed engine in vy_env Vladimir Davydov
2019-08-12 22:14 ` [tarantool-patches] " Konstantin Osipov
2019-08-14 13:09 ` Vladimir Davydov
2019-08-10 10:03 ` [PATCH 02/13] vinyl: embed index in vy_lsm Vladimir Davydov
2019-08-12 22:14 ` [tarantool-patches] " Konstantin Osipov
2019-08-14 13:09 ` Vladimir Davydov
2019-08-10 10:03 ` [PATCH 03/13] vinyl: move reference counting from vy_lsm to index Vladimir Davydov
2019-08-12 22:16 ` [tarantool-patches] " Konstantin Osipov
2019-08-14 13:09 ` Vladimir Davydov
2019-08-10 10:03 ` [PATCH 04/13] vinyl: don't pin index for iterator lifetime Vladimir Davydov
2019-08-10 10:03 ` [PATCH 05/13] vinyl: don't exempt dropped indexes from dump and compaction Vladimir Davydov
2019-08-10 10:03 ` [PATCH 06/13] memtx: don't store pointers to index internals in iterator Vladimir Davydov
2019-08-12 22:21 ` Konstantin Osipov [this message]
2019-08-14 13:10 ` Vladimir Davydov
2019-08-10 10:03 ` [PATCH 07/13] memtx: use ref counting to pin indexes for snapshot Vladimir Davydov
2019-08-12 22:24 ` [tarantool-patches] " Konstantin Osipov
2019-08-13 10:56 ` Vladimir Davydov
2019-08-13 16:08 ` Georgy Kirichenko
2019-08-10 10:03 ` [PATCH 08/13] memtx: allow snapshot iterator to fail Vladimir Davydov
2019-08-12 22:25 ` [tarantool-patches] " Konstantin Osipov
2019-08-14 13:10 ` Vladimir Davydov
2019-08-10 10:03 ` [PATCH 09/13] memtx: enter small delayed free mode from snapshot iterator Vladimir Davydov
2019-08-12 22:27 ` [tarantool-patches] " Konstantin Osipov
2019-08-13 10:59 ` Vladimir Davydov
2019-08-10 10:03 ` [PATCH 10/13] wal: make wal_sync fail on write error Vladimir Davydov
2019-08-12 22:29 ` [tarantool-patches] " Konstantin Osipov
2019-08-14 16:48 ` Vladimir Davydov
2019-08-10 10:03 ` [PATCH 11/13] xrow: factor out helper for setting REPLACE request body Vladimir Davydov
2019-08-12 22:29 ` [tarantool-patches] " Konstantin Osipov
2019-08-14 13:11 ` Vladimir Davydov
2019-08-10 10:03 ` [PATCH 12/13] test: disable replication/on_schema_init Vladimir Davydov
2019-08-12 22:31 ` [tarantool-patches] " Konstantin Osipov
2019-08-10 10:03 ` [PATCH 13/13] relay: join new replicas off read view Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812222157.GY32337@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 06/13] memtx: don'\''t store pointers to index internals in iterator' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox