From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/3] txn: merge struct sql_txn into struct txn
Date: Tue, 13 Aug 2019 00:55:54 +0300 [thread overview]
Message-ID: <20190812215554.GN32337@atlas> (raw)
In-Reply-To: <f61b7549-121c-c516-7036-7a3ea6a1e61e@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/08/10 00:01]:
> > + char *name;
>
> 8. I didn't like that name is stored by pointer - it consumes more
> memory, and is slower. So I changed to name[1] with variable length
> tail. But is it an advisory fix, you can skip it if you think it
> complicates the code too much. See below and on the branch.
Vlad, please, stop this optimization craziness, come on, how big
of a deal is it to allocate a name once you already parsed the
statement to create this savepoint?
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-08-12 21:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 15:13 [tarantool-patches] [PATCH 0/3] Merge struct sql_txn into struct txn/savepoint Nikita Pettik
2019-08-07 15:13 ` [tarantool-patches] [PATCH 1/3] txn: move fk_deferred_count from psql_txn to txn Nikita Pettik
2019-08-09 20:59 ` [tarantool-patches] " Vladislav Shpilevoy
2019-08-15 11:03 ` n.pettik
2019-08-07 15:13 ` [tarantool-patches] [PATCH 2/3] txn: merge struct sql_txn into struct txn Nikita Pettik
2019-08-07 15:26 ` [tarantool-patches] " Konstantin Osipov
2019-08-09 21:02 ` Vladislav Shpilevoy
2019-08-12 21:55 ` Konstantin Osipov [this message]
2019-08-15 11:04 ` n.pettik
2019-08-15 22:03 ` Vladislav Shpilevoy
2019-08-16 18:52 ` n.pettik
2019-08-19 20:47 ` Vladislav Shpilevoy
2019-08-21 0:23 ` n.pettik
2019-08-21 20:45 ` Vladislav Shpilevoy
2019-08-07 15:13 ` [tarantool-patches] [PATCH 3/3] sql: use struct txn_savepoint as anonymous savepoint Nikita Pettik
2019-08-07 15:26 ` [tarantool-patches] Re: [PATCH 0/3] Merge struct sql_txn into struct txn/savepoint Konstantin Osipov
2019-08-22 11:56 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812215554.GN32337@atlas \
--to=kostja@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 2/3] txn: merge struct sql_txn into struct txn' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox