Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/3] Merge struct sql_txn into struct txn/savepoint
Date: Wed, 7 Aug 2019 18:26:41 +0300	[thread overview]
Message-ID: <20190807152641.GB24486@atlas> (raw)
In-Reply-To: <cover.1565190104.git.korablev@tarantool.org>

* Nikita Pettik <korablev@tarantool.org> [19/08/07 18:19]:
> Branch: https://github.com/tarantool/tarantool/tree/np/move-sql-structs-from-txn
> 
> As a one of final steps of merging SQL and NoSQL codebases, it is
> required to squash struct sql_txn and struct txn/struct txn_savepoint.
> struct sql_txn was needed to operate on named savepoints. Hence, it
> contains name of savepoint and a link to next savepoint. This patch-set
> adds optional name of savepoint to struct txn_savepoint and orginizes
> txn_savepoints into list. Head of list is held in stuct txn. Iterating
> over list allows to find savepoint by its name. Finally, after this
> procedure is completed, we can remove struct sql_txn and struct Savepoint.

Thanks for the patch, overall LGTM (but I did not look carefully).

-- 
Konstantin Osipov, Moscow, Russia

  parent reply	other threads:[~2019-08-07 15:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 15:13 [tarantool-patches] " Nikita Pettik
2019-08-07 15:13 ` [tarantool-patches] [PATCH 1/3] txn: move fk_deferred_count from psql_txn to txn Nikita Pettik
2019-08-09 20:59   ` [tarantool-patches] " Vladislav Shpilevoy
2019-08-15 11:03     ` n.pettik
2019-08-07 15:13 ` [tarantool-patches] [PATCH 2/3] txn: merge struct sql_txn into struct txn Nikita Pettik
2019-08-07 15:26   ` [tarantool-patches] " Konstantin Osipov
2019-08-09 21:02   ` Vladislav Shpilevoy
2019-08-12 21:55     ` Konstantin Osipov
2019-08-15 11:04     ` n.pettik
2019-08-15 22:03       ` Vladislav Shpilevoy
2019-08-16 18:52         ` n.pettik
2019-08-19 20:47           ` Vladislav Shpilevoy
2019-08-21  0:23             ` n.pettik
2019-08-21 20:45               ` Vladislav Shpilevoy
2019-08-07 15:13 ` [tarantool-patches] [PATCH 3/3] sql: use struct txn_savepoint as anonymous savepoint Nikita Pettik
2019-08-07 15:26 ` Konstantin Osipov [this message]
2019-08-22 11:56 ` [tarantool-patches] Re: [PATCH 0/3] Merge struct sql_txn into struct txn/savepoint Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190807152641.GB24486@atlas \
    --to=kostja@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH 0/3] Merge struct sql_txn into struct txn/savepoint' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox