Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] Improve operability of typeof() function
Date: Fri, 2 Aug 2019 13:52:45 +0300	[thread overview]
Message-ID: <20190802105245.qz2uqnab2ixi6hgk@tarantool.org> (raw)
In-Reply-To: <cover.1564247922.git.korablev@tarantool.org>

Hello,

On 27 Jul 21:45, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/compare/np/gh-4148-add-field-type-to-mem
> Issue: https://github.com/tarantool/tarantool/issues/4148
> 
> First patch adds field_type member to struct Mem. It allows to
> improve type calculation for NULL values: when value is fetched
> from tuple, field_type is assigned to the type of corresponding
> field in space format. So that NULL from field with INTEGER type
> now has INTEGER type, from REAL - REAL etc. The only exception is
> SCALAR type since it's not basic type but rather aggregation of
> types. Thus, NULL values from SCALAR field features default type
> (in the next patch it is changed to BOOLEAN).
> 
> Second patch switches default type of NULL literal to boolean as it
> was decided to do during numerous discussions in mailing list. See
> commit message for details.
> 
> Nikita Pettik (2):
>   sql: extend struct Mem with field_type member
>   sql: make default type of NULL be boolean

I've checked the patchset into master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2019-08-02 10:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-27 18:45 [tarantool-patches] " Nikita Pettik
2019-07-27 18:45 ` [tarantool-patches] [PATCH 1/2] sql: extend struct Mem with field_type member Nikita Pettik
2019-07-28 15:22   ` [tarantool-patches] " Vladislav Shpilevoy
2019-07-28 21:26     ` Konstantin Osipov
2019-07-31  9:14     ` n.pettik
2019-07-31 16:59       ` Vladislav Shpilevoy
2019-08-01 15:56         ` n.pettik
2019-08-01 23:11           ` Vladislav Shpilevoy
2019-08-02 10:02             ` n.pettik
2019-07-27 18:45 ` [tarantool-patches] [PATCH 2/2] sql: make default type of NULL be boolean Nikita Pettik
2019-08-02 10:52 ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190802105245.qz2uqnab2ixi6hgk@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH 0/2] Improve operability of typeof() function' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox