Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: imeevma@tarantool.org, v.shpilevoy@tarantool.org,
	tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2 1/2] lua: new function luaT_return_error()
Date: Wed, 31 Jul 2019 18:39:08 +0300	[thread overview]
Message-ID: <20190731153908.GA8113@atlas> (raw)
In-Reply-To: <20190731152324.4rraz2shvqnenaas@tkn_work_nb>

* Alexander Turenko <alexander.turenko@tarantool.org> [19/07/31 18:37]:
> > +/**
> > + * Return nil as the first return value and an error as the
> > + * second. The error is received using box_error_last().
> > + *
> > + * @param L Lua stack.
> > + */
> > +LUA_API int
> > +luaT_return_error(lua_State *L);
> 
> Maybe let the name be a bit more explicit, say,
> luaT_push_conventional_error(struct lua_State *L)?

Ugh. What is conventional? Conventions change.

-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2019-07-31 15:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 10:32 [tarantool-patches] [PATCH v2 0/2] sql: rework error handling in box.execute() imeevma
2019-07-31 10:32 ` [tarantool-patches] [PATCH v2 1/2] lua: new function luaT_return_error() imeevma
2019-07-31 15:23   ` [tarantool-patches] " Alexander Turenko
2019-07-31 15:39     ` Konstantin Osipov [this message]
2019-07-31 15:40     ` Vladislav Shpilevoy
2019-07-31 16:20       ` Imeev Mergen
2019-07-31 17:00         ` Vladislav Shpilevoy
2019-07-31 19:33           ` Konstantin Osipov
2019-08-01  8:35           ` Alexander Turenko
2019-07-31 19:32         ` Konstantin Osipov
2019-07-31 17:15   ` Vladislav Shpilevoy
2019-07-31 22:16     ` Mergen Imeev
2019-08-01 20:03       ` Vladislav Shpilevoy
2019-08-01  8:59     ` Mergen Imeev
2019-07-31 10:32 ` [tarantool-patches] [PATCH v2 2/2] sql: rework error handling in box.execute() imeevma
2019-07-31 22:23   ` [tarantool-patches] " Mergen Imeev
2019-08-02  5:39 ` [tarantool-patches] Re: [PATCH v2 0/2] " Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731153908.GA8113@atlas \
    --to=kostja@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH v2 1/2] lua: new function luaT_return_error()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox